[ https://issues.apache.org/jira/browse/HADOOP-11914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608378#comment-14608378 ]
Hadoop QA commented on HADOOP-11914: ------------------------------------ \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue} precommit patch detected. {color} | | {color:blue}0{color} | {color:blue} @author {color} | {color:blue} 0m 0s {color} | {color:blue} Skipping @author checks as test-patch.sh has been patched. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 0s {color} | {color:green} Patch does not generate ASF License warnings. {color} | | {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m 8s {color} | {color:green} There were no new shellcheck issues. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 0m 13s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12742832/HADOOP-11914.HADOOP-12111.04.patch | | git revision | HADOOP-12111 / c5815a6 | | Optional Tests | asflicense shellcheck | | uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Default Java | 1.7.0_55 | | Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0 /home/jenkins/tools/java/jdk1.7.0_55:1.7.0_55 | | shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider upgrading.) | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/7103/console | This message was automatically generated. > test-patch.sh confused by certain patch formats > ----------------------------------------------- > > Key: HADOOP-11914 > URL: https://issues.apache.org/jira/browse/HADOOP-11914 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus > Affects Versions: HADOOP-12111 > Reporter: Allen Wittenauer > Assignee: Kengo Seki > Priority: Critical > Attachments: HADOOP-11914.001.patch, HADOOP-11914.002.patch, > HADOOP-11914.HADOOP-12111.03.patch, HADOOP-11914.HADOOP-12111.04.patch > > > A simple patch example: > {code} > diff --git a/start-build-env.sh b/start-build-env.sh > old mode 100644 > new mode 100755 > {code} > start-build-env.sh will not show up in the changed files list and therefore > will not get run by shellcheck. -- This message was sent by Atlassian JIRA (v6.3.4#6332)