[
https://issues.apache.org/jira/browse/HADOOP-12116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HADOOP-12116:
-----------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 2.8.0
Status: Resolved (was: Patch Available)
+1 for the patch. I also tested this on Windows to confirm that the Cygwin
support still works for all of the main entry points. I committed it to
branch-2.
Just to reiterate Allen's earlier comment, there really is no general guarantee
of compatibility if multiple versions of the script files get mixed arbitrarily
in a single invocation. It's fine to do a little defensive coding around this
flag check, but it's just one example of the kind of thing that can go wrong.
Thank you for the patch, Li.
> Fix unrecommended syntax usages in hadoop/hdfs/yarn script for cygwin in
> branch-2
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-12116
> URL: https://issues.apache.org/jira/browse/HADOOP-12116
> Project: Hadoop Common
> Issue Type: Bug
> Components: scripts
> Reporter: Li Lu
> Assignee: Li Lu
> Fix For: 2.8.0
>
> Attachments: HADOOP-12116-branch-2.001.patch
>
>
> We're using syntax like "if $cygwin; then" which may be errorounsly evaluated
> into true if cygwin is unset. We need to fix this in branch-2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
