[
https://issues.apache.org/jira/browse/HADOOP-12196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14621691#comment-14621691
]
Hadoop QA commented on HADOOP-12196:
------------------------------------
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s
{color} | {color:blue} precommit patch detected. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
20s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
6s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} Patch has no whitespace issues. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 0m 30s {color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12744630/HADOOP-12196.HADOOP-12111.01.patch
|
| git revision | HADOOP-12111 / 8243608 |
| Optional Tests | asflicense shellcheck |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/dev-support-test/personality/hadoop.sh
|
| Default Java | 1.7.0_55 |
| Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0
/home/jenkins/tools/java/jdk1.7.0_55:1.7.0_55 |
| shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider
upgrading.) |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7224/console |
This message was automatically generated.
> shellcheck plugin is picking up target executables
> --------------------------------------------------
>
> Key: HADOOP-12196
> URL: https://issues.apache.org/jira/browse/HADOOP-12196
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Reporter: Allen Wittenauer
> Assignee: Kengo Seki
> Attachments: HADOOP-12196.HADOOP-12111.01.patch
>
>
> When hadoop-yarn-server-nodemanager is in the build, it generates
> target/native/target/usr/local/bin/(test-)container-executor. shellcheck
> picks these up and throws a "hGetContents: invalid argument (invalid byte
> sequence)" error.
> We need some sort of safety to determine if a file is binary or shell code
> and/or prevent target directories from getting picked up. I suspect the
> former to be more reliable than the latter since we can't assume maven.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
