[ 
https://issues.apache.org/jira/browse/HADOOP-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622054#comment-14622054
 ] 

Tsuyoshi Ozawa commented on HADOOP-10694:
-----------------------------------------

[~gopalv] Make sense. Could you fix checkstyle issue? Additionally, I think 
it's a good timing to fix asterisk import(
import java.io.*) though it's not related to the issue directly. I'm +1 if the 
comment is addressed.



> Remove synchronized input streams from Writable deserialization
> ---------------------------------------------------------------
>
>                 Key: HADOOP-10694
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10694
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: io
>            Reporter: Gopal V
>            Assignee: Gopal V
>              Labels: BB2015-05-TBR
>         Attachments: HADOOP-10694.1.patch, writable-read-sync.png
>
>
> Writable deserialization is slowing down due to a synchronized block within 
> DataInputBuffer$Buffer.
> ByteArrayInputStream::read() is synchronized and this shows up as a slow 
> uncontested lock.
> Hive ships with its own faster thread-unsafe version with 
> hive.common.io.NonSyncByteArrayInputStream.
> !writable-read-sync.png!
> The DataInputBuffer and Writable deserialization should not require a lock 
> per readInt()/read().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to