[ https://issues.apache.org/jira/browse/HADOOP-12178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625644#comment-14625644 ]
Yi Liu commented on HADOOP-12178: --------------------------------- Thanks Steve. {code} - } catch (Exception ex) { + } catch (IOException ex) { {code} I think changing {{Exception}} to {{IOException}} is unnecessary. If {{SaslPropertiesResolver.getInstance(conf)}} throws RTE, then {{doAs}} will also throws RTE, if we change it to IOE, it can't be caught , so {{if (saslRpcClient == null)}} can't reach, furthermore we need to handle other exception here. Others look good, just no need to change the exception. > NPE during handling of SASL setup if problem with SASL resolver class > --------------------------------------------------------------------- > > Key: HADOOP-12178 > URL: https://issues.apache.org/jira/browse/HADOOP-12178 > Project: Hadoop Common > Issue Type: Bug > Components: ipc > Affects Versions: 2.7.1 > Reporter: Steve Loughran > Assignee: Steve Loughran > Priority: Minor > Attachments: HADOOP-12178-001.patch > > > If there's any problem in the constructor of {{SaslRpcClient}}, then IPC > Client throws an NPE rather than forwarding the stack trace. This is because > the exception handler assumes that {{saslRpcClient}} is not null, that the > exception is related to the SASL setup itself. > The exception handler needs to check for {{saslRpcClient}} being null, and if > so, rethrow the exception -- This message was sent by Atlassian JIRA (v6.3.4#6332)