[ https://issues.apache.org/jira/browse/HADOOP-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14716040#comment-14716040 ]
Hadoop QA commented on HADOOP-12358: ------------------------------------ \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | pre-patch | 25m 48s | Pre-patch trunk has 4 extant Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 14 new or modified test files. | | {color:green}+1{color} | javac | 11m 53s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 11m 3s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 24s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 2m 49s | The applied patch generated 6 new checkstyle issues (total was 197, now 203). | | {color:red}-1{color} | whitespace | 0m 2s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. | | {color:green}+1{color} | install | 1m 33s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 5m 20s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | common tests | 26m 59s | Tests passed in hadoop-common. | | {color:red}-1{color} | mapreduce tests | 75m 43s | Tests failed in hadoop-mapreduce-client-jobclient. | | {color:red}-1{color} | hdfs tests | 161m 21s | Tests failed in hadoop-hdfs. | | | | 324m 8s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.mapreduce.security.ssl.TestEncryptedShuffle | | | hadoop.mapred.TestMiniMRChildTask | | | hadoop.conf.TestNoDefaultsJobConf | | | hadoop.mapred.TestJobSysDirWithDFS | | | hadoop.fs.TestDFSIO | | | hadoop.mapreduce.security.TestBinaryTokenFile | | | hadoop.mapred.TestReduceFetch | | | hadoop.mapreduce.v2.TestNonExistentJob | | | hadoop.ipc.TestMRCJCSocketFactory | | | hadoop.mapred.TestClusterMapReduceTestCase | | | hadoop.mapred.TestMRIntermediateDataEncryption | | | hadoop.mapred.TestReduceFetchFromPartialMem | | | hadoop.fs.TestFileSystem | | | hadoop.mapred.TestJobName | | | hadoop.mapreduce.TestMapReduceLazyOutput | | | hadoop.mapred.TestMiniMRWithDFSWithDistinctUsers | | | hadoop.mapred.TestSpecialCharactersInOutputPath | | | hadoop.mapreduce.security.TestMRCredentials | | | hadoop.mapred.TestMRCJCFileInputFormat | | | hadoop.mapred.TestMerge | | | hadoop.mapred.lib.TestDelegatingInputFormat | | | hadoop.mapred.TestMiniMRClasspath | | | hadoop.mapred.join.TestDatamerge | | | hadoop.mapreduce.v2.TestMRJobs | | | hadoop.cli.TestXAttrCLI | | | hadoop.cli.TestHDFSCLI | | | hadoop.cli.TestAclCLI | | | hadoop.cli.TestDeleteCLI | | | hadoop.cli.TestCryptoAdminCLI | | | hadoop.hdfs.TestLocalDFS | | | hadoop.cli.TestCacheAdminCLI | | Timed out tests | org.apache.hadoop.mapred.TestLazyOutput | | | org.apache.hadoop.mapreduce.TestChild | | | org.apache.hadoop.mapreduce.TestMRJobClient | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12752593/HADOOP-12358.03.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / c992bcf | | Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-HADOOP-Build/7533/artifact/patchprocess/trunkFindbugsWarningshadoop-hdfs.html | | checkstyle | https://builds.apache.org/job/PreCommit-HADOOP-Build/7533/artifact/patchprocess/diffcheckstylehadoop-common.txt | | whitespace | https://builds.apache.org/job/PreCommit-HADOOP-Build/7533/artifact/patchprocess/whitespace.txt | | hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7533/artifact/patchprocess/testrun_hadoop-common.txt | | hadoop-mapreduce-client-jobclient test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7533/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt | | hadoop-hdfs test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7533/artifact/patchprocess/testrun_hadoop-hdfs.txt | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/7533/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/7533/console | This message was automatically generated. > FSShell should prompt before deleting directories bigger than a configured > size > ------------------------------------------------------------------------------- > > Key: HADOOP-12358 > URL: https://issues.apache.org/jira/browse/HADOOP-12358 > Project: Hadoop Common > Issue Type: Bug > Components: fs > Reporter: Xiaoyu Yao > Assignee: Xiaoyu Yao > Attachments: HADOOP-12358.00.patch, HADOOP-12358.01.patch, > HADOOP-12358.02.patch, HADOOP-12358.03.patch > > > We have seen many cases with customers deleting data inadvertently with > -skipTrash. The FSShell should prompt user if the size of the data or the > number of files being deleted is bigger than a threshold even though > -skipTrash is being used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)