[ https://issues.apache.org/jira/browse/HADOOP-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730324#comment-14730324 ]
Jagadesh Kiran N commented on HADOOP-12375: ------------------------------------------- Changes are on changing script file hence no tests included. > Incomplete checking for findbugs executable > ------------------------------------------- > > Key: HADOOP-12375 > URL: https://issues.apache.org/jira/browse/HADOOP-12375 > Project: Hadoop Common > Issue Type: Sub-task > Components: yetus > Affects Versions: HADOOP-12111 > Reporter: Kengo Seki > Assignee: Jagadesh Kiran N > Labels: newbie > Attachments: HADOOP-12375.HADOOP-12111.00.patch, > HADOOP-12375.HADOOP-12111.01.patch, HADOOP-12375.HADOOP-12111.02.patch > > > In test-patch.d/findbugs.sh: > {code} > 65 function findbugs_is_installed > 66 { > 67 if [[ ! -e "${FINDBUGS_HOME}/bin/findbugs" ]]; then > 68 printf "\n\n%s is not executable.\n\n" "${FINDBUGS_HOME}/bin/findbugs" > 69 add_vote_table -1 findbugs "Findbugs is not installed." > 70 return 1 > 71 fi > 72 return 0 > 73 } > {code} > should be -x. -- This message was sent by Atlassian JIRA (v6.3.4#6332)