[ 
https://issues.apache.org/jira/browse/HADOOP-12350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739535#comment-14739535
 ] 

Chris Nauroth commented on HADOOP-12350:
----------------------------------------

bq. considering that Hadoop community is moving towards use of Slf4j, would the 
IOUtils be exposing an Api that that takes Slf4j?

I think that makes sense, but adding an overload of {{IOUtils#cleanup}} would 
require some wider cleanup across various sub-modules.  (If a caller explicitly 
passes {{null}}, then Java can't decide whether to dispatch to the Commons 
Logging version or the slf4j version.)

That also makes me wonder if it would impact downstream projects.  {{IOUtils}} 
is annotated {{Public}}.

Let's not try to do this within the scope of the current patch.

bq. Do you see issues in having this implemented on the NativeAzureFileSystem 
class itself and move away from using IOUtils?

I think it's fine to have a private {{cleanup}} helper method for now.  It can 
be refactored later when we figure out the best way to put a helper method in 
Hadoop Common.

> WASB Logging: Improve WASB Logging around deletes, reads and writes
> -------------------------------------------------------------------
>
>                 Key: HADOOP-12350
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12350
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: tools
>            Reporter: Dushyanth
>            Assignee: Dushyanth
>             Fix For: 2.8.0
>
>         Attachments: 0001-HADOOP-12350-Added-WASB-Logging-Statement.patch
>
>
> Logging around the WASB component is very limited and it is disabled by 
> default. This improvement is created to add logging around Reads, Writes and 
> Deletes when Azure Storage Exception to capture the blobs that hit the 
> exception. This information is useful while communicating with the Azure 
> storage team for debugging purposes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to