[jira] [Commented] (HADOOP-12385) include nested stack trace in SaslRpcClient.getServerToken()

[Chris Nauroth (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HADOOP-12385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14741742#comment-14741742
 ] 

Chris Nauroth commented on HADOOP-12385:
----------------------------------------

Hi [~ste...@apache.org].  This looks good.  I have a minor nitpick on these 
lines:

{code}
+          LOG.debug("tokens aren't supported for this protocol or user doesn't 
have one");
           return null; // tokens aren't supported or user doesn't have one
{code}

{code}
+          LOG.debug("client isn't using kerberos");
           return null; // client isn't using kerberos
{code}

{code}
+          LOG.debug("protocol doesn't use kerberos");
           return null; // protocol doesn't use kerberos
{code}

Now that you've added these log statements, the code is self-documenting, and 
the comments are redundant.  Would you please remove the comments?

> include nested stack trace in SaslRpcClient.getServerToken()
> ------------------------------------------------------------
>
>                 Key: HADOOP-12385
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12385
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 2.7.1
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: HADOOP-12385-001.patch, HADOOP-12385-002.patch
>
>
> The {{SaslRpcClient.getServerToken()}} method loses the stack traces when an 
> attempt to instantiate a {{TokenSelector}}. It should include them in the 
> generated exception



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)