[ https://issues.apache.org/jira/browse/HADOOP-11293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743574#comment-14743574 ]
Hadoop QA commented on HADOOP-11293: ------------------------------------ \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | patch | 0m 0s | The patch command could not apply the patch during dryrun. | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12698923/HADOOP-11293-branch-2-005.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | branch-2 / c951d56 | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/7659/console | This message was automatically generated. > Factor OSType out from Shell > ---------------------------- > > Key: HADOOP-11293 > URL: https://issues.apache.org/jira/browse/HADOOP-11293 > Project: Hadoop Common > Issue Type: Improvement > Components: fs, util > Affects Versions: 2.7.0 > Reporter: Yongjun Zhang > Assignee: Yongjun Zhang > Attachments: HADOOP-11293-branch-2-005.patch, HADOOP-11293.001.patch, > HADOOP-11293.002.patch, HADOOP-11293.003.patch, HADOOP-11293.004.patch, > HADOOP-11293.005.patch, HADOOP-11293.005.patch, HADOOP-11293.005.patch, > HADOOP-11293.005.patch > > > Currently the code that detects the OS type is located in Shell.java. Code > that need to check OS type refers to Shell, even if no other stuff of Shell > is needed. > I am proposing to refactor OSType out to its own class, so to make the > OSType easier to access and the dependency cleaner. > -- This message was sent by Atlassian JIRA (v6.3.4#6332)