[
https://issues.apache.org/jira/browse/HADOOP-12409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14743703#comment-14743703
]
Steve Loughran commented on HADOOP-12409:
-----------------------------------------
That's quite a big diff, isn't it?
# It might be safest to leave the YARN implementation where it is, as an empty,
deprecated subclass of the common one.
# this JIRA will need matching/linked ones in the YARN and MAPREDUCE projects,
with the same patch file submitted under each one.
Looking at uses of {{Clock}}, I see a bigger issue, which is that there are
lots of places which use Clock to time sleep intervals, e.g.
{{org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.CGroupsHandlerImpl}}.
This is dangerous as System time is not monotonic and can go backwards if NTP
tells it to. That's bad practise and moving the clock class doesn't address it
—merely makes it more obvious where it happens
> Move org.apache.hadoop.yarn.util.Clock and relative implementations to hadoop
> Common
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-12409
> URL: https://issues.apache.org/jira/browse/HADOOP-12409
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 3.0.0
> Reporter: Xianyin Xin
> Assignee: Xianyin Xin
> Priority: Minor
> Attachments: Hadoop-12409.001.patch
>
>
> It is widely used by MR and YARN.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
