[
https://issues.apache.org/jira/browse/HADOOP-11104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14903226#comment-14903226
]
Hadoop QA commented on HADOOP-11104:
------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 24m 30s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 10m 48s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 14m 48s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 30s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 38s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 2m 15s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 42s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 2m 43s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | common tests | 28m 22s | Tests failed in
hadoop-common. |
| | | 86m 19s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.ha.TestZKFailoverController |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12761524/HADOOP-11104.003.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / cc2b473 |
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7686/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7686/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7686/console |
This message was automatically generated.
> org.apache.hadoop.metrics2.lib.MetricsRegistry needs numerical parameter
> checking
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-11104
> URL: https://issues.apache.org/jira/browse/HADOOP-11104
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Ray Chiang
> Assignee: Ray Chiang
> Priority: Minor
> Labels: BB2015-05-TBR, newbie, supportability
> Attachments: HADOOP-11104.001.patch, HADOOP-11104.002.patch,
> HADOOP-11104.003.patch
>
>
> Passing a negative value to the interval field of
> MetricsRegistry#newQuantiles should throw a MetricsException with a clear
> error message. The current stack trace looks something like:
> java.lang.IllegalArgumentException: null
> at
> java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420)
> at
> org.apache.hadoop.metrics2.lib.MutableQuantiles.<init>(MutableQuantiles.java:107)
> at
> org.apache.hadoop.metrics2.lib.MetricsRegistry.newQuantiles(MetricsRegistry.java:200)
> Along similar lines, should the other methods like
> MetricsRegistry#newCounter() also have parameter checking for negative
> int/long values?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
