[
https://issues.apache.org/jira/browse/HADOOP-12465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14947682#comment-14947682
]
Hadoop QA commented on HADOOP-12465:
------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 17m 32s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 59s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 24s | There were no new javadoc
warning messages. |
| {color:red}-1{color} | release audit | 0m 20s | The applied patch generated
1 release audit warnings. |
| {color:green}+1{color} | checkstyle | 1m 8s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 29s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 52s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests | 8m 28s | Tests passed in
hadoop-common. |
| | | 49m 49s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12765034/MAPREDUCE-6496-01.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 99e5204 |
| Release Audit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7778/artifact/patchprocess/patchReleaseAuditProblems.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7778/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7778/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/7778/console |
This message was automatically generated.
> Incorrect javadoc in WritableUtils.java
> ---------------------------------------
>
> Key: HADOOP-12465
> URL: https://issues.apache.org/jira/browse/HADOOP-12465
> Project: Hadoop Common
> Issue Type: Bug
> Components: documentation
> Affects Versions: 2.7.1
> Reporter: Martin Petricek
> Assignee: Jagadesh Kiran N
> Priority: Minor
> Fix For: 2.7.2
>
> Attachments: MAPREDUCE-6496-00.patch, MAPREDUCE-6496-01.patch
>
>
> Documentation for writeVLong in WritableUtils states that "For
> -112 <= i <= 127, only one byte is used"
> Documentation for writeVInt states that "For -120 <= i <= 127, only one byte
> is used"
> writeVInt calls internally writeVLong, so the ranges are the same for both
> functions.
> After examining the code, I see that the documentation that is at writeVLong
> is correct.
> Documentation for writeVInt is therefore incorrect and should be fixed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
