[
https://issues.apache.org/jira/browse/HADOOP-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HADOOP-10775:
-----------------------------------
Hadoop Flags: Reviewed
+1 for patch v009. I confirmed a full test run on Windows.
Whitespace issues can be fixed on commit.
I have one more very minor nitpick.
{code}
- if (Shell.WINDOWS && !Shell.isJava7OrAbove()) {
- // On Java6 on Windows, we copied the file
- Assert.assertEquals(data.length, link.length());
- } else {
- // Otherwise, the target file size is zero
- Assert.assertEquals(0, link.length());
- }
+ // Otherwise, the target file size is zero
+ Assert.assertEquals(0, link.length());
{code}
Now that the conditional logic is gone, the "otherwise" phrasing of the comment
doesn't make sense. I think the whole comment can be removed at this point.
Feel free to drop it during the final commit. IMO, there is no need to go
through full review of another patch revision for this minor tweak.
[~ste...@apache.org], thank you for contributing the patch.
> Shell operations to fail with meaningful errors on windows if winutils.exe
> not found
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-10775
> URL: https://issues.apache.org/jira/browse/HADOOP-10775
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: trunk-win, 2.7.1
> Environment: windows
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: HADOOP-10775-002.patch, HADOOP-10775-003.patch,
> HADOOP-10775-004.patch, HADOOP-10775-005.patch, HADOOP-10775-006.patch,
> HADOOP-10775-007.patch, HADOOP-10775-008.patch, HADOOP-10775-009.patch,
> HADOOP-10775.patch
>
>
> If {{winutils.exe}} can't be found {{HADOOP_HOME}} wrong/unset or other
> causes, then an error is logged -but when any of the {{Shell}} operations are
> used, an NPE is raised rather than something meaningful.
> The error message at setup time should be preserved and then raised before
> any attempt to invoke a winutils-driven process made
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
