[ https://issues.apache.org/jira/browse/HADOOP-12364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955884#comment-14955884 ]
Allen Wittenauer commented on HADOOP-12364: ------------------------------------------- Looks good. At least, I'm not seeing anything obviously wrong. Minor nit: {code} + hadoop_error "WARNING: deamon pid has changed for ${command}, skip deleting deamon pid file" {code} spelling errors. :) > Deleting pid file after stop is causing the daemons to keep restarting > ----------------------------------------------------------------------- > > Key: HADOOP-12364 > URL: https://issues.apache.org/jira/browse/HADOOP-12364 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 2.6.0 > Reporter: Siqi Li > Assignee: Siqi Li > Priority: Minor > Attachments: HADOOP-12364.v1.patch, HADOOP-12364.v2.patch, > HADOOP-12364.v3.patch, HADOOP-12364.v4.patch > > > pid files are deleting in 5 seconds after we stop the daemons. If a start > command were executed within the 5 seconds, the pid file will be overwrite > with a new pid. However, this pid file is going to be deleted by the former > stop command. This is causing the monitoring service to lose track of the > daemons, hence keep rebooting them -- This message was sent by Atlassian JIRA (v6.3.4#6332)