[ https://issues.apache.org/jira/browse/HADOOP-12053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986009#comment-14986009 ]
Chris Nauroth commented on HADOOP-12053: ---------------------------------------- The patch adds test {{TestHarFileSystemBasics#testCheckPath}}, but I'm not sure the test really covers the bug. I tried reverting the main code change and running the test, and it still passed. Ideally, we'd have a test that fails before the fix and then passes after the fix. One of the comments mentions a connection to HADOOP-12304, which in turn relates back to HADOOP-11618. I'm trying to assess what is the best course of action for the 2.7 line now. If we had a test that demonstrates the bug, then that would help me understand. Thanks! > Harfs defaulturiport should be Zero ( should not -1) > ---------------------------------------------------- > > Key: HADOOP-12053 > URL: https://issues.apache.org/jira/browse/HADOOP-12053 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 2.7.0 > Reporter: Brahma Reddy Battula > Assignee: Gera Shegalov > Priority: Critical > Attachments: HADOOP-12053.001.patch, HADOOP-12053.002.patch, > HADOOP-12053.003.patch > > > The harfs overrides the "getUriDefaultPort" method of AbstractFilesystem, and > returns "-1" . But "-1" can't pass the "checkPath" method when the > {{fs.defaultfs}} is setted without port(like hdfs://hacluster) > *Test Code :* > {code} > for (FileStatus file : files) { > String[] edges = file.getPath().getName().split("-"); > if (applicationId.toString().compareTo(edges[0]) >= 0 && > applicationId.toString().compareTo(edges[1]) <= 0) { > Path harPath = new Path("har://" + > file.getPath().toUri().getPath()); > harPath = harPath.getFileSystem(conf).makeQualified(harPath); > remoteAppDir = LogAggregationUtils.getRemoteAppLogDir( > harPath, applicationId, appOwner, > LogAggregationUtils.getRemoteNodeLogDirSuffix(conf)); > if > (FileContext.getFileContext(remoteAppDir.toUri()).util().exists(remoteAppDir)) > { > remoteDirSet.add(remoteAppDir); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)