[ 
https://issues.apache.org/jira/browse/HADOOP-12560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997546#comment-14997546
 ] 

Alan Burlison commented on HADOOP-12560:
----------------------------------------

I think you need to be a little careful because "integer type" doesn't 
necessarily mean "C int type" but it appears both uid_t and gid_t are 32 bits 
even when the app is LP64, so PRId32 seems like the right one.

> Fix sprintf warnings in {{DomainSocket.c}} introduced by HADOOP-12344
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-12560
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12560
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 2.8.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Mingliang Liu
>         Attachments: HADOOP-12560.000.patch
>
>
> Fix sprintf warnings in {{DomainSocket.c}} introduced by HADOOP-12344
> {code}
>      [exec] 
> op/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c:488:10:
>  warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 
> has type ‘long long int’ [-Wformat=]
>      [exec]           check, path, mode, (long long)st.st_uid, (long 
> long)st.st_gid, check);
>      [exec]           ^
>      [exec] 
> /pool/home/alanbur/bigdata/hadoop/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c:488:10:
>  warning: format ‘%ld’ expects argument of type ‘long int’, but argument 7 
> has type ‘long long int’ [-Wformat=]
>      [exec] 
> /pool/home/alanbur/bigdata/hadoop/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c:500:10:
>  warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 
> has type ‘long long int’ [-Wformat=]
>      [exec]           check, check);
>      [exec]           ^
>      [exec] 
> /pool/home/alanbur/bigdata/hadoop/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c:500:10:
>  warning: format ‘%ld’ expects argument of type ‘long int’, but argument 7 
> has type ‘long long int’ [-Wformat=]
>      [exec] 
> /pool/home/alanbur/bigdata/hadoop/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c:513:10:
>  warning: format ‘%ld’ expects argument of type ‘long int’, but argument 6 
> has type ‘long long int’ [-Wformat=]
>      [exec]           (long long)uid, check, (long long)uid, check);
>      [exec]           ^
>      [exec] 
> /pool/home/alanbur/bigdata/hadoop/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c:513:10:
>  warning: format ‘%ld’ expects argument of type ‘long int’, but argument 7 
> has type ‘long long int’ [-Wformat=]
>      [exec] 
> /pool/home/alanbur/bigdata/hadoop/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c:513:10:
>  warning: format ‘%ld’ expects argument of type ‘long int’, but argument 8 
> has type ‘long long int’ [-Wformat=]
>      [exec] 
> /pool/home/alanbur/bigdata/hadoop/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c:513:10:
>  warning: format ‘%ld’ expects argument of type ‘long int’, but argument 10 
> has type ‘long long int’ [-Wformat=]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to