OKAY, I got my mailing lists straightened out with Jakarta, so now I can email my own stuff.
I have implemented this scheme and it works. Well, it builds anyway, and I still need to test it some more to see that nothing is broken, but I am reasonably confident it will work exactly as the old implementation did. It's just a moving around of code. Question is whether I should shoot for this to be in 1.0 or confine changes to the "proposal section" for now. ----------------------------------------------- Steve Cohen Sr. Software Engineer Sportvision Inc. [EMAIL PROTECTED] http://www.sportvision.com Please note: As a result of the merger of Ignite Sports and Sportvision, my email address has changed to [EMAIL PROTECTED] -----Original Message----- From: Jeffrey D. Brekke [mailto:[EMAIL PROTECTED]] Sent: Sunday, January 26, 2003 10:35 PM To: [EMAIL PROTECTED]; Steve Cohen Subject: [net] Refactoring of ftp2 As requested I'm reposting an email from Steve Cohen ( [EMAIL PROTECTED] ) about possible refactorings he's working on in the code moved into proposal/ftp2. -- My curiosity being piqued, I decided to take a closer look at what it might take to actually merge the ftp2 concepts in to the main stem. The following refactoring plan jumps out at me: 1) Move the interface o.a.c.net.ftp.ftp2.FTPFileEntryParser to o.a.c.net.ftp. 2) Create an abstract class o.a.c.net.ftp.FTPFileListParserImpl to implement BOTH FTPFileListParser and FTPFileEntryParser. This abstract class will HAVE an implementation of a) delegating to the entry parser implementing in terms of b) which will be an empty method in the abstract. It will also contain all the functionality now in o.a.net.ftp.ftp2.parser.MatchApparatus. o.a.net.ftp.ftp2.FTPFileList would either become part of this class as well, or be moved and used by it. 3) Move all the o.a.c.net.ftp.ftp2.parser classes to a new package o.a.c.net.ftp.parser and rewrite them to extend FTPFileListParserImpl. I may be oversimplifying slightly, but this scheme would allow all the new parsing functionality I introduced to integrate seamlessly with the old system while totally preserving backward compatibility. I think it would be much easier for end-users to understand than the ftp2 mess. Steve -- ===================================================================== Jeffrey D. Brekke [EMAIL PROTECTED] Wisconsin, USA [EMAIL PROTECTED] [EMAIL PROTECTED] -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
