If Lang itself did not build under 1.2, I'd think it is bad. I don't think
we can trust a Lang that builds under 1.4 to necessarily work on all
platforms.
Currently the tests use the classes to build. Probably they should run
against the built jar so a 1.2 built jar can be tested comfortably under
1.2, 1.3 and 1.4.
If Tests fail under 1.2 for some reason, I figure it's not so bad if we
understand why [ie it is a 1.3/1.4] feature, and we can just use
SystemUtils to protect the test and it will effectively build.
If the tests don't build under 1.2, as is currently the case, I think it's
the same as Lang not building. It's in need of a fix.
My view :)
Hen
On Tue, 29 Jul 2003, Phil Steitz wrote:
> I ran into this same problem, but did not mention it since I thought that the
> expectation was that the code built on 1.4 would *run* on 1.2+ The tests that
> I have been doing with 1.3 and 1.2 have used code and tests compiled using 1.4.
> Am I testing the wrong way? What exactly does it mean in Status.html when it
> says
>
> "The Lang component is dependent upon the following external components for
> development and use:
>
> Java Development Kit (Version 1.2 or later)"
>
> Does this mean that you can build components that use [lang] (jars) using JDK
> 1.2 (possible now) or that you can build [lang] itself using JDK 1.2 (not
> possible now)? What is the Commons policy on this?
>
> Phil
>
>
> --- Henri Yandell <[EMAIL PROTECTED]> wrote:
> >
> > Just downloaded the 1.2.2 to my new linux dev-server. Up until now I've
> > been building under 1.3 and 1.4.
> >
> > src/test/org/apache/commons/lang/enum/OperationEnum.java does not build
> > under 1.2.2/Linux due to:
> >
> > [javac]
> >
> /home/hen/jakarta/branch2.0/jakarta-commons/lang/src/test/org/apache/commons/lang/enum/OperationEnum.java:67:
> > class org.apache.commons.lang.enum.OperationEnum is an abstract class. It
> > can't be instantiated.
> > [javac] public static final OperationEnum PLUS = new
> > OperationEnum("Plus") {
> > [javac] ^
> > [javac]
> >
> /home/hen/jakarta/branch2.0/jakarta-commons/lang/src/test/org/apache/commons/lang/enum/OperationEnum.java:72:
> > class org.apache.commons.lang.enum.OperationEnum is an abstract class. It
> > can't be instantiated.
> > [javac] public static final OperationEnum MINUS = new
> > OperationEnum("Minus") {
> > [javac] ^
> >
> > It appears to get confused. So I made OperationEnumPlus and
> > OperationEnumMinus which extend OperationEnum and have the specific
> > eval(int,int) method.
> >
> > However, using this the tests fail. It seems as though the Plus and Minus
> > enums are not getting registered in the static part of Enum:
> >
> > [java] There were 4 failures:
> > [java] 1)
> >
> testOperationGet(org.apache.commons.lang.enum.EnumTest)junit.framework.AssertionFailedError:
> > expected same:<OperationEnumPlus[Plus]> was not:<null>
> > [java] at
> > org.apache.commons.lang.enum.EnumTest.testOperationGet(EnumTest.java:187)
> > [java] 2)
> >
> testOperationList(org.apache.commons.lang.enum.EnumTest)junit.framework.AssertionFailedError:
> > expected:<2> but was:<0>
> > [java] at
> > org.apache.commons.lang.enum.EnumTest.testOperationList(EnumTest.java:204)
> > [java] 3)
> >
> testOperationMap(org.apache.commons.lang.enum.EnumTest)junit.framework.AssertionFailedError
> > [java] at
> > org.apache.commons.lang.enum.EnumTest.testOperationMap(EnumTest.java:217)
> > [java] 4)
> >
> testOperationToString(org.apache.commons.lang.enum.EnumTest)junit.framework.ComparisonFailure:
> > expected:<......> but was:<...Plus...>
> > [java] at
> >
> org.apache.commons.lang.enum.EnumTest.testOperationToString(EnumTest.java:198)
> >
> > [java] FAILURES!!!
> >
> >
> > Any ideas?
> >
> > Hen
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
>
>
> __________________________________
> Do you Yahoo!?
> Yahoo! SiteBuilder - Free, easy-to-use web site design software
> http://sitebuilder.yahoo.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
