hi norm

committed. many thanks.

i've added some documentation into the beanutils package.html (which is where the main beanutils documentation lives). feel free to expand and enhance it if you wish :)

- robert

On Wednesday, August 27, 2003, at 04:36 PM, Norm Deane wrote:

I've attached a zip file which includes the java files for the
Predicate, Closure, and Transformer along with their respective test
cases.  I wasn't sure what release these might make it into so I did NOT
include an @since in my JavaDocs.  I also included a patch for a couple
very minor changes I made to TestBean to support some of my test cases.

--Norm

--
Norm Deane
MIS Consultant
Vanderbilt University
(615) 322-7855
[EMAIL PROTECTED]

-----Original Message-----
From: Norm Deane [mailto:[EMAIL PROTECTED]
Sent: Tuesday, August 26, 2003 2:00 PM
To: 'Jakarta Commons Developers List'
Subject: RE: [beanutils][collections] Transformer, Predicate, and
Closure Implementation


Not a problem. I will add the license and e-mail the new files along with test cases later this week. Unless someone speaks up I will leave the package as is.

--Norm

--
Norm Deane
MIS Consultant
Vanderbilt University
(615) 322-7855
[EMAIL PROTECTED]

-----Original Message-----
From: robert burrell donkin
[mailto:[EMAIL PROTECTED]
Sent: Sunday, August 24, 2003 4:04 AM
To: Jakarta Commons Developers List
Subject: Re: [beanutils][collections] Transformer, Predicate, and
Closure Implementation


hi norm


i've taken a look and these look pretty cool and i'd be interested in
adding them to beanutils. there are a few issues that should be
discussed
before i'd be willing to make this happen:

1. the apache license has not been included at the top of each file.
since
this assigns copyright to the ASF it's taken as a sufficient indication
that you are willing to donate the code. please either resubmit with the

ASF license at the top of each source file or confirm to the list that
you
want to donate this code.

2, would you be willing to create and donate some unit tests for these
class? (all new code should have unit tests and if you're not willing to

create them that means a committer must which is extra work and may lead

to the item sinking down the list of priorities...)

3. packaging. as submitted, these classes will be placed in the root
beanutils package. if there are going to be a lot of other stuff along
similar lines, maybe it'd be better to create a new package. comments
anyone?

- robert

On Thursday, August 21, 2003, at 06:45 PM, Norm Deane wrote:

I recently implemented a Closure, Transformer, and Predicate which
make use of PropertyUtils to provide some useful functionality when
dealing with Collections of beans.  I wanted to offer them up as a
candidate for the BeanUtils package and/or get some feedback from the
list.

--> BeanPropertyValueChangeClosure is an implementation of
Closure</code> that updates a specified property on the object
provided with a specified value.

--> BeanPropertyValueEqualsPredicate is an implementation of Predicate
that evaluates a property value on the object provided against a
specified value and returns true if equal; false otherwise.

--> BeanToPropertyValueTransformer is an implementation of Transformer
that transforms the object provided by returning the value of a
specified property of the object.


Thanks,


Norm


-- Norm Deane MIS Consultant Vanderbilt University (615) 322-7855 [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

  ---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to