> -----Original Message----- > --- Martin Cooper <[EMAIL PROTECTED]> wrote: > > On Mon, 29 Mar 2004, Niall Pemberton wrote: > > > > > I think its the ExceptionTest which is failing and it looks like it > > should > > > from the code. There are three tests in ExceptionTest - only one has > > code to > > > "pass" the test if it gets the Exception its expecting - the other two > > are > > > set to "fail". > > > > > > The two test which have failures have code to "pass" the test if the > > > expected Exception is received but its been commented out and replaced > > with > > > "fail" code. Theres a note saying "This will be true in Validator 2.0" > > above > > > the commented out code in one of the tests but that doesn't really > > explain > > > why the tests have been set up to throw an exception and then "fail". > > > > > > I think the bugs are in the test! > > > > No, the problems I'm seeing are definitely in the e-mail tests. I've > > attached the Maven rest reports for the e-mail and exception tests, in > > which you can see that the former failed, while the latter succeeded. > > The email tests are known to fail because there is a known bug in > EmailValidator. I setup the exception tests and they should pass even > though exceptions may get thrown. The stack traces you're seeing is > commons-logging at work :-). > > I believe Rob knows more about the email situation but I think it's fine > to release with the bug that's been known for a while now.
Correct, these tests are supposed to fail. Basically, the way we do email validation is inadequate. I have a (java not javascript)version based on a Perl version that firsts iteratively strips off any comments before further validation. I wouldn't want to check those changes in since they are far from complete, though I could check in the accompaning perl scripts as DOCUMENTATION if someone else wants to jive it a shot. > > David > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
