Agreed, ( but ListUnivariateImpl is somewhat of a throw-away test fixture ).
In general, I agree that tests should not swallow exceptions.  I've just
commit'd a change in the same vein.




> -----Original Message-----
> From: Phil Steitz [mailto:[EMAIL PROTECTED]
> Sent: Saturday, May 22, 2004 8:41 PM
> To: Jakarta Commons Developers List
> Subject: Re: cvs commit: jakarta-
> commons/math/src/test/org/apache/commons/math/stat/univariate
> ListUnivariateImpl.java
> 
> We should also fix the "swallowing" behavior -- i.e., a test case should
> never swallow an exception and just dump a stack trace.  If the test case
> throws an unexpected exception, the test should fail.  I have been fixing
> these by changing the test method signature to throws Exception.  This
> also eliminates the need to import MathException everywhere.
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to