Sorry for the lack of conformity, I will get right on that. (I pulled this code from our project where the standard is XxxTEST, and I've never used Maven.)
Re: the array - yeah, that was a last-minute change away from arrays in the reader, an oversight I forgot to correct in the writer. > However, I am not a Codec developer so I believe you should expect > someone of the developers to evaluate this more. That would be good to get - can someone look at the implementation and say whether this looks good for inclusion (assuming I fix the conformity issues Paul brought up). Mostly I'm concerned about two things: * does the API seem usable (obviously I'll fix the oversight in the writer API) * does the list of tests seem like a reasonable coverage Because if the code doesn't pass on those grounds then all the work I might do for conformity will be for naught. :-) Tim > -----Original Message----- > From: Paul Libbrecht [mailto:[EMAIL PROTECTED] > Sent: Friday, September 24, 2004 3:58 AM > To: Tim Dawson; Jakarta Commons Developers List > Subject: Re: CSV submission for jakarta-commons > > Hi, > > I've taken a small look and found the following: > - your test-cases should be in a separate directory and named "TestXXX" > - inserting this into codec at the appropriate place, renaming, and > building does build the tests fine. Maybe you could re-post (say, on a > private URL), a version where that is fixed. > - running maven site (you need to check-out commons-build as well) does > show some checkstyle lacks in your code (quite small). Alternatively, > run "maven checkstyle", then "maven xdoc". > - you seem to be missing a package.html. > - the javadoc of CSVParser could be somewhat richer, e.g. with example > usage. From it, I seem to be able to make a jelly tag-lib, I think > (which is my interest) > - you have a writeRecord(String[]) but the reading doesn't handle > arrays, why not having a writeCol(String) as well ? > - your link to "Creativyst" doesn't go "_top" > > However, I am not a Codec developer so I believe you should expect > someone of the developers to evaluate this more. > > paul > > > Le 24 sept. 04, à 04:07, Tim Dawson a écrit : > > I haven't heard anything since my last note; I'm sure everybody's busy > > with other stuff and I know that bugzilla isn't the most friendly > > thing to use (has anybody discussed switching this project to JIRA?). > > Anyway, the attachment on the bugzilla issue I submitted doesn't seem > > to want to download correctly, but if you rename the .cgi file it > > creates to .zip it's actually fine. > > > > But since I was sending out an email anyway to the small group of > > people who expressed interest anyway, I attached the zip file (it was > > small) in order to further reduce any barrier we might have for > > review. I'd love to get your comments. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
