Having a quick peek, I don't see any code in there to handle X being 10. Have you tested it for an ISBN with an X of 10 yet. Currently it looks as though it strips out X's.
Submitting a unit-test class as well is always very useful, especially with new classes. Hen On Thu, 30 Sep 2004 12:53:43 +0200, Mark Lowe <[EMAIL PROTECTED]> wrote: > Hello > > I've just written an ISBN validator I don't think i can diff a file > that doesn't exist. But i'd like to see if its of use to anyone other > than myself. > > I've attached it and i'll just check the commons stuff out of cvs and > see if there's a jalopy template that could iron out anything that > would be displeasing to anyone in terms of coding. > > What do i have to do to get this committed? > > I still need to add an option to switch checking the regular expression > off in case folk want to use it to check numbers with no hyphens or > spaces. At the moment the input can be either. > > Mark > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
