At one time we had all sorts of abstraction somewhere in there.. I think for example JNDIConfiguration supported "removing" properites by holding them in a temporary list of properties that had been removed. If getProperty() found that the list had a property with that name, then it returned null, otherwise it called getPropertyDirect which ACTUALLY returned the property.
Icky, I know, and getting rid of it has my earnest +1! Just the similiarity of the names always seemed like a code smell to me. Eric > -----Original Message----- > From: Emmanuel Bourg [mailto:[EMAIL PROTECTED] > Sent: Thursday, December 02, 2004 6:51 PM > To: Jakarta Commons Developers List > Subject: [configuration] getProperty vs getPropertyDirect > > > Dumb question of the day : what's the usefulness of getPropertyDirect ? > I cleaned a bit the code by removing the redundant getProperty > implementation in CompositeConfiguration and JNDIConfiguration, now the > only implementation left is in AbstractConfiguration and it delegates > directly to getPropertyDirect. > > So at this point it seems getPropertyDirect is no longer necessary, I > suggest merging it into getProperty. > > Emmanuel Bourg > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
