Hi Simon,
I have now committed the first proposal for the XMLIO like rule
manager called SupplementaryRuleManager. I also added a very basic
test for it. I had to make a minor visibility change in
DefaultRuleManager that it extends. Path now has match methods.
All this isn't perfect, especially Javadoc is missing and tests need
to be extended, but I wanted to make this public for discussion as
soon as possible.
So, comments?
And, by the, now that I have done some work and I came across some new
questions. Maybe they are just dumb, but what do you think about this?
(1) Why aren't relative paths to actions also cached?
(2) Why are the guts of Context accessible to the Action as well? They
should only be interesting to the Digester core, not to the
application. Why not adding an interface that hides the implentation
details? Like
public interface Context {
Path getCurrentPath();
String getMatchPath();
ClassLoader getClassLoader();
Object getRoot();
boolean isEmpty();
int getStackSize();
Object peek();
Object peek(int n);
putItem(ItemId id, Object data);
Object getItem(ItemId id);
}
and ContextImpl being what Context is now. Similar thing with Path. If
you agree I could do the work.
(3) Bringing this up again: Wouldn't it be more flexible to allow more
than a String as a pattern in RuleManager#addRule(String pattern,
Action action)?
Oliver
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
