Okay...
I have fixed the NOTICE.txt in the jar at the top level not being in the
META-INF. However, I can't seem to get the NOTICE.txt in the top level
of either the src or binary distributions. The postGoal in commons
build here doesn't seem to run. No xdocs, no jars, no NOTICE.txt...:
<postGoal name="dist:prepare-src-filesystem">
<j:set var="maven.dist.src.assembly.dir"
value="${pom.getPluginContext('maven-dist-plugin').getVariable('maven.di
st.src.assembly.dir')}" />
<!-- Copy Files -->
<ant:copy todir="${maven.dist.src.assembly.dir}">
<ant:fileset dir=".">
<ant:include name="NOTICE.txt"/>
</ant:fileset>
</ant:copy>
<!-- Copy Jars -->
<ant:copy todir="${maven.dist.src.assembly.dir}">
<ant:fileset dir="${maven.build.dir}">
<ant:include name="*.jar"/>
</ant:fileset>
</ant:copy>
<!-- Copy XDocs -->
<ant:copy todir="${maven.dist.src.assembly.dir}/xdocs">
<ant:fileset dir="xdocs" />
</ant:copy>
</postGoal>
To what extent is the NOTICE.txt a mandatory requriement? TO me, it
looks just like the LICENSE.txt...
And, in the interests of finally getting a release out, especially since
we have the required +1 votes, can I just add the file by hand? Icky, I
know, but...
Eric
-----Original Message-----
From: Phil Steitz [mailto:[EMAIL PROTECTED]
Sent: Wednesday, March 02, 2005 3:49 PM
To: Jakarta Commons Developers List
Subject: Re: [VOTE] Release commons email 1.0
+1 modulo the following nits:
* Binary distro includes NOTICE.txt in the jar (top level, should
probably be with LICENSE.txt in META-INF) but not in the top level
directory of the distribution.
* Source distro does not include NOTICE.txt
* Ant build.xml in source distro fails with MalformedURLException in get
deps. When I regenerated the build.xml using maven ant, the regenerated
build.xml worked. Could be build.xml is out of date?
* Make sure to update the repo link on the web site to point to svn.
Phil
robert burrell donkin wrote:
> On Tue, 2005-03-01 at 06:58, Eric Pugh wrote:
>
>>[X] +1 Lets release commons-email, it's been too long!
>>[ ] 0 Commons-what? Not ready for release
>>[ ] -1 Don't release. I can't get dumbster (replace with your
>>reason) to work.
>
>
> BTW i've checked the sums and signatures
>
> - robert
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
