svn commit: r156933 - in jakarta/commons/proper/httpclient/branches/HTTPCLIENT_2_0_BRANCH: release_notes.txt src/java/org/apache/commons/httpclient/HttpConnection.java

[oglueck]

Author: oglueck
Date: Thu Mar 10 02:33:41 2005
New Revision: 156933

URL: http://svn.apache.org/viewcvs?view=rev&rev=156933
Log:
Fixed exception in HttpConnection because of unchecked buffer size

PR: 33947
Reviewed by: Oleg Kalnichevsku, Jorge Gonzales Varela

Modified:
    
jakarta/commons/proper/httpclient/branches/HTTPCLIENT_2_0_BRANCH/release_notes.txt
    
jakarta/commons/proper/httpclient/branches/HTTPCLIENT_2_0_BRANCH/src/java/org/apache/commons/httpclient/HttpConnection.java

Modified: 
jakarta/commons/proper/httpclient/branches/HTTPCLIENT_2_0_BRANCH/release_notes.txt
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/httpclient/branches/HTTPCLIENT_2_0_BRANCH/release_notes.txt?view=diff&r1=156932&r2=156933
==============================================================================
--- 
jakarta/commons/proper/httpclient/branches/HTTPCLIENT_2_0_BRANCH/release_notes.txt
 (original)
+++ 
jakarta/commons/proper/httpclient/branches/HTTPCLIENT_2_0_BRANCH/release_notes.txt
 Thu Mar 10 02:33:41 2005
@@ -1,3 +1,6 @@
+Changes since Release 2.0.2
+ * 33947 - Exception in HttpConnection because of unchecked buffer size
+
 Release 2.0.2
 -------------------
 Changes since Release 2.0.1

Modified: 
jakarta/commons/proper/httpclient/branches/HTTPCLIENT_2_0_BRANCH/src/java/org/apache/commons/httpclient/HttpConnection.java
URL: 
http://svn.apache.org/viewcvs/jakarta/commons/proper/httpclient/branches/HTTPCLIENT_2_0_BRANCH/src/java/org/apache/commons/httpclient/HttpConnection.java?view=diff&r1=156932&r2=156933
==============================================================================
--- 
jakarta/commons/proper/httpclient/branches/HTTPCLIENT_2_0_BRANCH/src/java/org/apache/commons/httpclient/HttpConnection.java
 (original)
+++ 
jakarta/commons/proper/httpclient/branches/HTTPCLIENT_2_0_BRANCH/src/java/org/apache/commons/httpclient/HttpConnection.java
 Thu Mar 10 02:33:41 2005
@@ -1,7 +1,7 @@
 /*
  * $Header: 
/home/jerenkrantz/tmp/commons/commons-convert/cvs/home/cvs/jakarta-commons//httpclient/src/java/org/apache/commons/httpclient/HttpConnection.java,v
 1.67.2.13 2004/09/06 17:41:45 olegk Exp $
  * $Revision: 1.67.2.13 $
- * $Date: 2004/09/06 17:41:45 $
+ * $Date$
  *
  * ====================================================================
  *
@@ -80,7 +80,7 @@
  * @author Eric E Johnson
  * @author Laura Werner
  * 
- * @version   $Revision: 1.67.2.13 $ $Date: 2004/09/06 17:41:45 $
+ * @version   $Revision: 1.67.2.13 $ $Date$
  */
 public class HttpConnection {
 
@@ -684,11 +684,11 @@
                 socket.setSendBufferSize(sendBufferSize);
             }
             int outbuffersize = socket.getSendBufferSize();
-            if (outbuffersize > 2048) {
+            if ((outbuffersize > 2048) || (outbuffersize <= 0)) {
                 outbuffersize = 2048;
             }
             int inbuffersize = socket.getReceiveBufferSize();
-            if (inbuffersize > 2048) {
+            if ((inbuffersize > 2048) || (inbuffersize <= 0)) {
                 inbuffersize = 2048;
             }
             inputStream = new BufferedInputStream(



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]