DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=32590>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32590





------- Additional Comments From [EMAIL PROTECTED]  2005-05-27 01:29 -------
I don't think it is safe to modify this code to throw anything other than an
IllegalArgumentException; that could break user code.

But we could make the string message in the IllegalArgumentException more 
helpful.

The getSimpleProperty method already throws a nice selection of different
exceptions. In particular, it throws InvocationTargetException in the case that
this bugzilla entry is about.

So I would suggest this:
 try {
   value = ...
 } catch(IllegalArgumentException ..) {
    throw new IllegalArgumentException("...");
 } catch(InvocationTargetException ex) {
    throw new IllegalArgumentException(
      "An exception was thrown by the getter method for property + "  name);
 } catch(NoSuchMethodException ex) {
    // throw IllegalArgumentException with appropriate
    // message here...
 } catch(Throwable ex) {
    // throw IllegalArgumentException with appropriate
    // message here...
 }

And of course the javadoc would need a little update too.

Comments?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to