Simon, Thanks for the tests. Glad to hear 1.5 is clean.
I found the same errors with the DateUtilsTest and I've got a fix ready to check in. I was waiting until we resolved these other issues. There is a tag for RC6 but not for the RC6a because I built it from the head and from a couple of local changes. I plan to build an RC7 with the test source and configuration fixes and cross my fingers that it will be the golden one. On 5/26/05, Simon Kitching <[EMAIL PROTECTED]> wrote: > > Hi, > > ==== > with lang/trunk: > "maven clean test" works for me with java1.5 on linux > "ant clean dist-build-2.1 test" works for me with java1.5 on linux > > with the contents of file commons-lang-2.1-RC6a-src.tar.gz: > "maven clean test" works for me with java1.5 on linux > "ant clean dist-build-2.1 test" works for me with java1.5 on linux > > I used junit-3.8.1 with ant. > > ==== > "maven clean test" on lang/trunk or with the download RC6a file fails > with java1.3.1 on linux: > [junit] Tests run: 40, Failures: 1, Errors: 0, Time elapsed: 4.995 sec > [junit] [ERROR] TEST org.apache.commons.lang.time.TimeTestSuite FAILED > > $ cat target/test-reports/ > TEST-org.apache.commons.lang.time.TimeTestSuite.txt > > Testcase: testRound(org.apache.commons.lang.time.DateUtilsTest): > FAILED > round MET date across DST change-over expected:<Sun Mar 30 03:00:00 IRST > 2003> but was:<Sun Mar 30 02:00:00 IRST 2003> > junit.framework.AssertionFailedError: round MET date across DST > change-over expected:<Sun Mar 30 03:00:00 IRST 2003> but was:<Sun Mar 30 > 02:00:00 IRST 2003> > at > org.apache.commons.lang.time.DateUtilsTest.testRound(DateUtilsTest.java > :472) > > $ java -version > java version "1.3.1_14" > Java(TM) 2 Runtime Environment, Standard Edition (build 1.3.1_14-b03) > Java HotSpot(TM) Client VM (build 1.3.1_14-b03, mixed mode) > ==== > > I did not get the reported problem: > > [java] Class not found "org.apache.commons.lang.LangTestSuite" > > ==== > > I don't see any RC6 directory under lang/tags. I presume the .tar.gz > file on your site is actually from HEAD? > > ==== > > Regards, > > Simon > > On Thu, 2005-05-26 at 20:05 -0400, Steven Caswell wrote: > > That is so very odd. I'm at a loss to explain it. I don't have access to > a > > system with JDK 1.3 so I'm not able to try it. Maybe someone else can > try? > > > > One thing I did find I needed to do was to change th junit version in > > default.properties from 3.7 to 3.8.1. Gary, could you try making this > change > > and building under 1.3.1? I'm just curious to see if this makes a > > difference, though I don't see why it should. > > > > Thanks. > > > > On 5/25/05, Gary Gregory <[EMAIL PROTECTED]> wrote: > > > > > > Steven: > > > > > > I updated from CVS today and got new build.xml. I still get the error > > > below on Sun Java 1.3.1_14. > > > > > > Thanks, > > > > > > Gary > > > > > > ------------------------------ > > > > > > *From:* Gary Gregory > > > *Sent:* Tuesday, May 24, 2005 7:12 PM > > > *To:* 'Steven Caswell' > > > *Cc:* Jakarta Commons Developers List > > > *Subject:* RE: [lang] DateUtils test fails under 1.2.2 and not under > 1.4.2 > > > > > > Steven: > > > > > > (You're welcome.) > > > > > > Downloaded RC6a-src and I am now experiencing Weirdness: I run "ant > clean > > > dist-build-2.1 test" which works fine on Sun Java 1.4.2_08. > > > > > > On Sun Java 1.3.1_14 I get: > > > > > > test.lang: > > > > > > [echo] Running lang package tests ... > > > > > > [java] Class not found "org.apache.commons.lang.LangTestSuite" > > > > > > BUILD FAILED > > > > > > C:\temp\commons-lang-2.1-RC6\build.xml:166: Java returned: 1 > > > > > > Which makes no sense at first glance. > > > > > > Gary > > > > > > ------------------------------ > > > > > > *From:* Steven Caswell [mailto:[EMAIL PROTECTED] > > > *Sent:* Tuesday, May 24, 2005 7:00 PM > > > *To:* Gary Gregory > > > *Cc:* Jakarta Commons Developers List > > > *Subject:* Re: [lang] DateUtils test fails under 1.2.2 and not under > 1.4.2 > > > > > > Gary, > > > > > > I put up the revised source distribution in > > > http://www.apache.org/~stevencaswell/commons-lang-2.1< > http://www.apache.org/%7Estevencaswell/commons-lang-2.1> > > > > > > I named them commons-lang-2.1-RC6a-src.* so you could easily tell they > are > > > modified. I was just too lazy to change it to RC7 for a minor non-code > fix, > > > and since there will probably be an RC7 with the date utils test > change. > > > > > > Thanks for your patience and thanks for testing these things. > > > > > > On 5/24/05, *Steven Caswell* <[EMAIL PROTECTED] > wrote: > > > > > > Gary, > > > > > > I have a fix for that problem. I'll go ahead and put up a corrected > source > > > distribution with the fix and without the DateUtilsTest correction so > you > > > can try 1.3.1. > > > > > > On 5/24/05, *Gary Gregory* <[EMAIL PROTECTED] > wrote: > > > > > > I'd like to check 1.3.1 but... running "ant clean build-dist-2.1 test" > > > from src-zip does not make it past text tests: > > > > > > test.text: > > > [echo] Running text package tests ... > > > [java] Class not found " org.apache.commons.lang.text.TextTestSuite" > > > > > > BUILD FAILED > > > C:\temp\commons-lang-2.1-RC6\build.xml:206: Java returned: 1 > > > > > > Which should not be run in the 1st place... > > > > > > (Ant 1.6.4 and Java 1.4.2_08) > > > > > > Gary > > > > > > -----Original Message----- > > > From: Steven Caswell [mailto:[EMAIL PROTECTED] > > > Sent: Tuesday, May 24, 2005 5:39 PM > > > To: Jakarta Commons Developers List > > > Subject: [lang] DateUtils test fails under 1.2.2 and not under 1.4.2 > > > > > > All, > > > > > > I have discovered a group of tests in the DateUtils test case that > fails > > > > > > under 1.2.2 but not under 1.4.2. They are testing the DateUtils round > > > method > > > when rounding a date in the MET timezone across the start and end of > > > DST. If > > > I remember correctly, this was in response to a user bug report. In > > > particular the test is at line 472 of the testRound method in > > > DataUtilsTest.java. > > > > > > The test passes fine when run under 1.4.2 but fails under 1.2.2. I > don't > > > > > > have a 1.3 installation available so I don't know if it passes or > fails > > > under 1.3. > > > > > > I propose that we put a condition around the test so that is only run > > > when > > > the Java version is 1.4, and add a note to the round method javadoc > and > > > the > > > release notes stating that the round method may not work properly in > all > > > > > > cases involving DST rollovers in previous JVMs, with this case as an > > > example. > > > > > > Thoughs? > > > > > > -- > > > Steven Caswell > > > [EMAIL PROTECTED] > > > > > > Take back the web - http://www.mozilla.org > > > > > > > > > > > > > > > -- > > > Steven Caswell > > > [EMAIL PROTECTED] > > > > > > Take back the web - http://www.mozilla.org > > > > > > > > > > > > > > > -- > > > Steven Caswell > > > [EMAIL PROTECTED] > > > > > > Take back the web - http://www.mozilla.org > > > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > -- Steven Caswell [EMAIL PROTECTED] Take back the web - http://www.mozilla.org
