DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=34661>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=34661 ------- Additional Comments From [EMAIL PROTECTED] 2005-06-02 09:51 ------- Hi Brian, As part of your patch to add a configurable "ignore flawed discovery" feature, could you please consider handing the cast to Log in this line: logAdapter = (Log) constructor.newInstance(params); separately from the other exceptions? Currently, the code catches all throwables and passes the exception down to handleFlawedDiscovery, which then assumes that a ClassCastException was due to casting the result to Log. This isn't necessarily true. I think it would be nice if the return value from constructor.newInstance was initially treated as an Object. Casting could then be done in a separate try/catch clause, and only ClassCastException in *that* block would mean calling reportInvalidLogAdapter. Anyway, I think it's worth considering...and as I know you're already working on these methods it didn't seem wise for me to be working on the same code at the same time :). PS: When affectState is false, do wewant to call handleFlawedDiscovery? I suspect not.. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
