On Fri, 2005-06-24 at 09:37 +1200, Simon Kitching wrote: > On Fri, 2005-06-24 at 08:59 +1200, Simon Kitching wrote: > > One unit test failed with Java 1.3 (debian sarge): > > > > Testcase: > > testIntrospectionTimeTypeWrite(org.apache.commons.betwixt.io.read.TestBindTimeTypeMapping): > > FAILED > > (Unequal node names) expected:<call> but was:<latinName> > > junit.framework.ComparisonFailure: (Unequal node names) expected:<call> > > but was:<latinName> > > at > > org.apache.commons.betwixt.xmlunit.XmlTestCase.testIsomorphic(XmlTestCase.java:214) > > at > > org.apache.commons.betwixt.xmlunit.XmlTestCase.testIsomorphic(XmlTestCase.java:312) > > at > > org.apache.commons.betwixt.xmlunit.XmlTestCase.testIsomorphic(XmlTestCase.java:312) > > at > > org.apache.commons.betwixt.xmlunit.XmlTestCase.xmlAssertIsomorphic(XmlTestCase.java:175) > > at > > org.apache.commons.betwixt.xmlunit.XmlTestCase.xmlAssertIsomorphicContent(XmlTestCase.java:128) > > at > > org.apache.commons.betwixt.xmlunit.XmlTestCase.xmlAssertIsomorphicContent(XmlTestCase.java:105) > > at > > org.apache.commons.betwixt.xmlunit.XmlTestCase.xmlAssertIsomorphicContent(XmlTestCase.java:96) > > at > > org.apache.commons.betwixt.io.read.TestBindTimeTypeMapping.testIntrospectionTimeTypeWrite(TestBindTimeTypeMapping.java:232) > > I modified the test briefly with some println statements, and it looks > like another case of different property order in the output. Method > testIsomorphic doesn't seem to be working correctly in this case. > > But anyway, is it really a good idea to allow the output to vary > according to what the JVM-of-the-moment decides? Perhaps betwixt should > always sort properties by alphabetical order so that behaviour is then > identical across JVMs....
Actually, it appears that this particular test wasn't using the "orderIndependent" flag for the xml test. Enabling this makes the test pass. I still think having betwixt order the properties is a good idea though..but maybe for the next release. Line 229 of TestBindTimeTypeMappping: - xmlAssertIsomorphicContent(parseString(expected), parseString(out)); + xmlAssertIsomorphicContent(parseString(expected), parseString(out), true); Regards, Simon --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
