Some style checkers won't allow you to have empty code blocks. You must at least have one empty statement.
-----Original Message----- From: Gary Gregory [mailto:[EMAIL PROTECTED] Sent: Monday, June 27, 2005 4:54 PM To: Jakarta Commons Developers List Subject: added empty statement to empty catch blocks [WAS: svn commit: r202043 - in /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang: NumberUtils.java SerializationUtils.java enum/Enum.java enums/Enum.java math/NumberUtils.java] Hello: What is the reason for this change? - //Too big for a long + ; //Too big for a long It looks very odd to me. Thanks, Gary -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Monday, June 27, 2005 1:24 PM To: [EMAIL PROTECTED] Subject: svn commit: r202043 - in /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang: NumberUtils.java SerializationUtils.java enum/Enum.java enums/Enum.java math/NumberUtils.java Author: stevencaswell Date: Mon Jun 27 13:24:10 2005 New Revision: 202043 URL: http://svn.apache.org/viewcvs?rev=202043&view=rev Log: added empty statement to empty catch blocks Modified: jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/Numbe rUtils.java jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/Seria lizationUtils.java jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/ Enum.java jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enums /Enum.java jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/math/ NumberUtils.java Modified: jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/Numbe rUtils.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/lang/trunk/src/java /org/apache/commons/lang/NumberUtils.java?rev=202043&r1=202042&r2=202043 &view=diff ======================================================================== ====== --- jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/Numbe rUtils.java (original) +++ jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/Numbe rUtils.java Mon Jun 27 13:24:10 2005 @@ -197,7 +197,7 @@ try { return createLong(numeric); } catch (NumberFormatException nfe) { - //Too big for a long + ; //Too big for a long } return createBigInteger(numeric); Modified: jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/Seria lizationUtils.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/lang/trunk/src/java /org/apache/commons/lang/SerializationUtils.java?rev=202043&r1=202042&r2 =202043&view=diff ======================================================================== ====== --- jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/Seria lizationUtils.java (original) +++ jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/Seria lizationUtils.java Mon Jun 27 13:24:10 2005 @@ -114,7 +114,7 @@ out.close(); } } catch (IOException ex) { - // ignore; + ; // ignore } } } @@ -170,7 +170,7 @@ in.close(); } } catch (IOException ex) { - // ignore + ; // ignore } } } Modified: jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/ Enum.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/lang/trunk/src/java /org/apache/commons/lang/enum/Enum.java?rev=202043&r1=202042&r2=202043&v iew=diff ======================================================================== ====== --- jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/ Enum.java (original) +++ jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/ Enum.java Mon Jun 27 13:24:10 2005 @@ -548,11 +548,11 @@ String name = (String) mth.invoke(other, null); return iName.equals(name); } catch (NoSuchMethodException e) { - // ignore - should never happen + ; // ignore - should never happen } catch (IllegalAccessException e) { - // ignore - should never happen + ; // ignore - should never happen } catch (InvocationTargetException e) { - // ignore - should never happen + ; // ignore - should never happen } return false; } Modified: jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enums /Enum.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/lang/trunk/src/java /org/apache/commons/lang/enums/Enum.java?rev=202043&r1=202042&r2=202043& view=diff ======================================================================== ====== --- jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enums /Enum.java (original) +++ jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enums /Enum.java Mon Jun 27 13:24:10 2005 @@ -548,11 +548,11 @@ String name = (String) mth.invoke(other, null); return iName.equals(name); } catch (NoSuchMethodException e) { - // ignore - should never happen + ; // ignore - should never happen } catch (IllegalAccessException e) { - // ignore - should never happen + ; // ignore - should never happen } catch (InvocationTargetException e) { - // ignore - should never happen + ; // ignore - should never happen } return false; } Modified: jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/math/ NumberUtils.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/lang/trunk/src/java /org/apache/commons/lang/math/NumberUtils.java?rev=202043&r1=202042&r2=2 02043&view=diff ======================================================================== ====== --- jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/math/ NumberUtils.java (original) +++ jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/math/ NumberUtils.java Mon Jun 27 13:24:10 2005 @@ -456,7 +456,7 @@ try { return createLong(numeric); } catch (NumberFormatException nfe) { - //Too big for a long + ; //Too big for a long } return createBigInteger(numeric); --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
