Author: stevencaswell
Date: Tue Jul 5 18:15:52 2005
New Revision: 209373
URL: http://svn.apache.org/viewcvs?rev=209373&view=rev
Log:
removed empty statement from catch block that takes no action, using comment
only to denote no action;
added super to empty constructors
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/Enum.java
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/ExceptionUtils.java
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/math/NumberUtils.java
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/Enum.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/Enum.java?rev=209373&r1=209372&r2=209373&view=diff
==============================================================================
---
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/Enum.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/enum/Enum.java
Tue Jul 5 18:15:52 2005
@@ -293,7 +293,7 @@
* <p>Restrictive constructor.</p>
*/
private Entry() {
- ; // empty constructor
+ super();
}
}
@@ -548,11 +548,11 @@
String name = (String) mth.invoke(other, null);
return iName.equals(name);
} catch (NoSuchMethodException e) {
- ; // ignore - should never happen
+ // ignore - should never happen
} catch (IllegalAccessException e) {
- ; // ignore - should never happen
+ // ignore - should never happen
} catch (InvocationTargetException e) {
- ; // ignore - should never happen
+ // ignore - should never happen
}
return false;
}
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/ExceptionUtils.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/ExceptionUtils.java?rev=209373&r1=209372&r2=209373&view=diff
==============================================================================
---
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/ExceptionUtils.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/exception/ExceptionUtils.java
Tue Jul 5 18:15:52 2005
@@ -91,7 +91,7 @@
* to be created, although that is not normally necessary.</p>
*/
public ExceptionUtils() {
- ; // empty constructor
+ super();
}
//-----------------------------------------------------------------------
@@ -294,20 +294,20 @@
try {
method = throwable.getClass().getMethod(methodName, null);
} catch (NoSuchMethodException ignored) {
- ; // exception ignored
+ // exception ignored
} catch (SecurityException ignored) {
- ; // exception ignored
+ // exception ignored
}
if (method != null &&
Throwable.class.isAssignableFrom(method.getReturnType())) {
try {
return (Throwable) method.invoke(throwable,
ArrayUtils.EMPTY_OBJECT_ARRAY);
} catch (IllegalAccessException ignored) {
- ; // exception ignored
+ // exception ignored
} catch (IllegalArgumentException ignored) {
- ; // exception ignored
+ // exception ignored
} catch (InvocationTargetException ignored) {
- ; // exception ignored
+ // exception ignored
}
}
return null;
@@ -325,18 +325,18 @@
try {
field = throwable.getClass().getField(fieldName);
} catch (NoSuchFieldException ignored) {
- ; // exception ignored
+ // exception ignored
} catch (SecurityException ignored) {
- ; // exception ignored
+ // exception ignored
}
if (field != null &&
Throwable.class.isAssignableFrom(field.getType())) {
try {
return (Throwable) field.get(throwable);
} catch (IllegalAccessException ignored) {
- ; // exception ignored
+ // exception ignored
} catch (IllegalArgumentException ignored) {
- ; // exception ignored
+ // exception ignored
}
}
return null;
@@ -387,9 +387,9 @@
return true;
}
} catch (NoSuchMethodException ignored) {
- ; // exception ignored
+ // exception ignored
} catch (SecurityException ignored) {
- ; // exception ignored
+ // exception ignored
}
}
@@ -399,9 +399,9 @@
return true;
}
} catch (NoSuchFieldException ignored) {
- ; // exception ignored
+ // exception ignored
} catch (SecurityException ignored) {
- ; // exception ignored
+ // exception ignored
}
return false;
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/math/NumberUtils.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/math/NumberUtils.java?rev=209373&r1=209372&r2=209373&view=diff
==============================================================================
---
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/math/NumberUtils.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/math/NumberUtils.java
Tue Jul 5 18:15:52 2005
@@ -82,7 +82,7 @@
* to operate.</p>
*/
public NumberUtils() {
- ; // empty constructor
+ super();
}
//-----------------------------------------------------------------------
@@ -456,7 +456,7 @@
try {
return createLong(numeric);
} catch (NumberFormatException nfe) {
- ; //Too big for a long
+ //Too big for a long
}
return createBigInteger(numeric);
@@ -473,7 +473,7 @@
}
} catch (NumberFormatException nfe) {
- ; // empty catch
+ // ignore the bad number
}
//Fall through
case 'd' :
@@ -484,12 +484,12 @@
return d;
}
} catch (NumberFormatException nfe) {
- ; // empty constructor
+ // ignore the bad number
}
try {
return createBigDecimal(numeric);
} catch (NumberFormatException e) {
- ; // empty constructor
+ // ignore the bad number
}
//Fall through
default :
@@ -509,12 +509,12 @@
try {
return createInteger(str);
} catch (NumberFormatException nfe) {
- ; // empty contructor
+ // ignore the bad number
}
try {
return createLong(str);
} catch (NumberFormatException nfe) {
- ; // empty constructor
+ // ignore the bad number
}
return createBigInteger(str);
@@ -527,7 +527,7 @@
return f;
}
} catch (NumberFormatException nfe) {
- ; // empty constructor
+ // ignore the bad number
}
try {
Double d = createDouble(str);
@@ -535,7 +535,7 @@
return d;
}
} catch (NumberFormatException nfe) {
- ; // empty constructor
+ // ignore the bad number
}
return createBigDecimal(str);
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
