Fixed in SVN and added a unit test to match. My bad for not checking that a unit test was in place before mod'ing.
Thanks Stephen for catching this. Gary > -----Original Message----- > From: Stephen Colebourne [mailto:[EMAIL PROTECTED] > Sent: Sunday, August 21, 2005 12:51 PM > To: Jakarta Commons Developers List > Subject: Re: svn commit: r234327 - > /jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/text /S > trTokenizer.java > > [EMAIL PROTECTED] wrote: > > Unnecessary cast from char[] to char[]. > > StrTokenizer cloned = (StrTokenizer) super.clone(); > > if (cloned.chars != null) { > > - cloned.chars = (char[]) cloned.chars; > > + cloned.chars = cloned.chars; > > } > > cloned.reset(); > > return cloned; > > should be > cloned.chars = (char[]) cloned.chars.clone(); > > Stephen > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
