Author: henning Date: Thu Aug 25 03:03:05 2005 New Revision: 240033 URL: http://svn.apache.org/viewcvs?rev=240033&view=rev Log: Remove trailing blanks
Modified: jakarta/commons/proper/email/trunk/maven.xml jakarta/commons/proper/email/trunk/project.xml jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/BaseEmailTestCase.java jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/EmailTest.java jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/HtmlEmailTest.java jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/MultiPartEmailTest.java jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockEmailConcrete.java jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockHtmlEmailConcrete.java jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockMultiPartEmailConcrete.java jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockSimpleEmail.java jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/settings/EmailConfiguration.java jakarta/commons/proper/email/trunk/xdocs/changes.xml jakarta/commons/proper/email/trunk/xdocs/examples.xml jakarta/commons/proper/email/trunk/xdocs/index.xml jakarta/commons/proper/email/trunk/xdocs/navigation.xml Modified: jakarta/commons/proper/email/trunk/maven.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/maven.xml?rev=240033&r1=240032&r2=240033&view=diff ============================================================================== --- jakarta/commons/proper/email/trunk/maven.xml (original) +++ jakarta/commons/proper/email/trunk/maven.xml Thu Aug 25 03:03:05 2005 @@ -16,7 +16,7 @@ limitations under the License. --> -<project +<project xmlns:ant="jelly:ant" xmlns:j="jelly:core" default="jar:jar"> @@ -31,16 +31,16 @@ <j:if test="${context.getVariable('commons.basedir.available') == null}"> <fail> ------------------------------------------------------------------------------ -| if you want to build xdocs or the site, you must -| check out the 'commons-build' module from +| if you want to build xdocs or the site, you must +| check out the 'commons-build' module from | http://svn.apache.org/repos/asf/jakarta/commons/proper/commons-build/trunk/ | and put it in a directory next to commons-email ------------------------------------------------------------------------------ </fail> </j:if> - </preGoal> + </preGoal> - <postGoal name="xdoc:copy-resources"> + <postGoal name="xdoc:copy-resources"> <copy todir="${basedir}/target/docs/style/" failonerror="false"> <fileset dir="${basedir}/../commons-build/xdocs/style"> <include name='**/*'/> @@ -51,8 +51,8 @@ <!-- ================================================================== --> <!-- END: C O M M O N S - B U I L D --> <!-- ================================================================== --> - - <!-- Ensures that the conf directory and NOTICE.txt are included in the + + <!-- Ensures that the conf directory and NOTICE.txt are included in the source distro. --> <postGoal name="dist:prepare-src-filesystem"> @@ -66,14 +66,14 @@ <fileset file="${basedir}/RELEASE-NOTES.txt"/> </copy> </postGoal> - + <!-- Ensures that NOTICE.txt is added to the binary distro --> <preGoal name="dist:build-bin"> <copy todir="${maven.dist.bin.assembly.dir}"> <fileset file="${basedir}/NOTICE.txt"/> <fileset file="${basedir}/RELEASE-NOTES.txt"/> </copy> - + <!-- include listed dependencies that we are allowed to distribute--> <j:forEach var="dep" items="${pom.dependencies}"> <j:if test="${dep.getProperty('dist.bundle') != null && dep.getProperty('dist.bundle').equalsIgnoreCase('true')}"> @@ -85,5 +85,5 @@ <fileset file="${basedir}/conf/LIBS-NOTICE.txt"/> </copy> </preGoal> - + </project> Modified: jakarta/commons/proper/email/trunk/project.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/project.xml?rev=240033&r1=240032&r2=240033&view=diff ============================================================================== --- jakarta/commons/proper/email/trunk/project.xml (original) +++ jakarta/commons/proper/email/trunk/project.xml Thu Aug 25 03:03:05 2005 @@ -20,7 +20,7 @@ <groupId>commons-email</groupId> <artifactId>commons-email</artifactId> <currentVersion>1.0-rc7-dev</currentVersion> - + <organization> <name>The Apache Software Foundation</name> <url>http://jakarta.apache.org</url> @@ -34,7 +34,7 @@ <distribution>repo</distribution> </license> </licenses> - + <inceptionYear>2001</inceptionYear> <package>org.apache.commons.mail</package> <logo>/images/email-logo-white.png</logo> @@ -191,11 +191,11 @@ <version>1.6</version> <url>http://quintanasoft.com/dumbster/</url> </dependency> - <dependency> - <groupId>maven-plugins</groupId> - <artifactId>maven-findbugs-plugin</artifactId> - <version>0.9.1</version> - <url>http://maven-plugins.sourceforge.net/maven-findbugs-plugin/</url> + <dependency> + <groupId>maven-plugins</groupId> + <artifactId>maven-findbugs-plugin</artifactId> + <version>0.9.1</version> + <url>http://maven-plugins.sourceforge.net/maven-findbugs-plugin/</url> <type>plugin</type> </dependency> </dependencies> @@ -236,7 +236,7 @@ <report>maven-pmd-plugin</report> <report>maven-license-plugin</report> <report>maven-jcoverage-plugin</report> - <report>maven-findbugs-plugin</report> + <report>maven-findbugs-plugin</report> </reports> <properties/> </project> Modified: jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java?rev=240033&r1=240032&r2=240033&view=diff ============================================================================== --- jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java (original) +++ jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java Thu Aug 25 03:03:05 2005 @@ -857,7 +857,7 @@ throws EmailException { Validate.notNull(this.message,"message"); - + try { Transport.send(this.message); @@ -869,11 +869,11 @@ + this.getHostName() + ":" + this.getSmtpPort(); - + throw new EmailException(msg,t); } } - + /** * Returns the internal MimeMessage. Please not that the * MimeMessage is build by the buildMimeMessage() method. @@ -884,7 +884,7 @@ { return this.message; } - + /** * Sends the email. Internally we build a MimeMessage * which is afterwards sent to the SMTP server. @@ -897,7 +897,7 @@ this.buildMimeMessage(); return this.sendMimeMessage(); } - + /** * Sets the sent date for the email. The sent date will default to the * current date if not explictly set. @@ -924,7 +924,7 @@ } return this.sentDate; } - + /** * Gets the subject of the email. * @@ -934,7 +934,7 @@ { return this.subject; } - + /** * Gets the sender of the email. * @@ -944,7 +944,7 @@ { return this.fromAddress; } - + /** * Gets the host name of the SMTP server, * @@ -954,7 +954,7 @@ { return this.hostName; } - + /** * Gets the listening port of the SMTP server. * @@ -964,7 +964,7 @@ { return this.smtpPort; } - + /** * Utility to copy List of known InternetAddress objects into an * array. Modified: jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/BaseEmailTestCase.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/BaseEmailTestCase.java?rev=240033&r1=240032&r2=240033&view=diff ============================================================================== --- jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/BaseEmailTestCase.java (original) +++ jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/BaseEmailTestCase.java Thu Aug 25 03:03:05 2005 @@ -66,25 +66,25 @@ public static final int BODY_END_PAD = 3; /** Padding at start of body added by dumbser/send */ public static final int BODY_START_PAD = 2; - + /** Where to save email output **/ private File emailOutputDir; /** Test characters acceptable to email */ - protected String[] testCharsValid = + protected String[] testCharsValid = { - " ", - "a", - "A", - "\uc5ec", - "0123456789", - "012345678901234567890", + " ", + "a", + "A", + "\uc5ec", + "0123456789", + "012345678901234567890", "\n" }; - + /** Array of test strings */ - protected String[] testCharsNotValid = { "", null }; - + protected String[] testCharsNotValid = { "", null }; + /** * @param name name */ @@ -117,7 +117,7 @@ } /** - * + * * @param email email * @throws IOException Exception */ @@ -138,15 +138,15 @@ { assertTrue(this.fakeMailServer.getReceivedEmailSize() >= intMsgNo); Iterator emailIter = fakeMailServer.getReceivedEmail(); - SmtpMessage emailMessage = null; + SmtpMessage emailMessage = null; for (int intCurMsg = 0; intCurMsg < intMsgNo; intCurMsg++) { emailMessage = (SmtpMessage) emailIter.next(); } - + if (emailMessage != null) { - return emailMessage.toString(); + return emailMessage.toString(); } fail("Message note found"); return ""; @@ -236,7 +236,7 @@ bccAdd.toString().indexOf(emailMessage.getHeaderValue("Bcc")) != -1); } - + return emailMessage; } @@ -278,12 +278,12 @@ // get sent email content String strSentContent = content.getContentType(); - // get received email content (chop off the auto-added \n + // get received email content (chop off the auto-added \n // and -- (front and end) String strMessageBody = emailMessage.getBody().substring( BaseEmailTestCase.BODY_START_PAD, - emailMessage.getBody().length() + emailMessage.getBody().length() - BaseEmailTestCase.BODY_END_PAD); assertTrue(strMessageBody.indexOf(strSentContent) != -1); } Modified: jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/EmailTest.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/EmailTest.java?rev=240033&r1=240032&r2=240033&view=diff ============================================================================== --- jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/EmailTest.java (original) +++ jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/EmailTest.java Thu Aug 25 03:03:05 2005 @@ -80,7 +80,7 @@ } /** - * + * * @throws Exception Exception */ public void testGetSetSession() throws Exception @@ -99,7 +99,7 @@ this.email.setMailSession(mySession); assertEquals(mySession, this.email.getMailSession()); - + } /** */ @@ -110,7 +110,7 @@ String strPassword = "user.pwd"; this.email.setAuthentication(strUsername, strPassword); - // this is cast into DefaultAuthenticator for convenience + // this is cast into DefaultAuthenticator for convenience // and give us access to the getPasswordAuthentication fn DefaultAuthenticator retrievedAuth = (DefaultAuthenticator) this.email.getAuthenticator(); @@ -136,7 +136,7 @@ new DefaultAuthenticator(strUsername, strPassword); this.email.setAuthenticator(authenicator); - // this is cast into DefaultAuthenticator for convenience + // this is cast into DefaultAuthenticator for convenience // and give us access to the getPasswordAuthentication fn DefaultAuthenticator retrievedAuth = (DefaultAuthenticator) this.email.getAuthenticator(); @@ -280,7 +280,7 @@ } /** - * + * * @throws Exception Exception */ public void testSetFrom() throws Exception @@ -311,7 +311,7 @@ for (int i = 0; i < ARR_VALID_EMAILS.length; i++) { - // set from + // set from this.email.setFrom(ARR_VALID_EMAILS[i]); // retrieve and verify @@ -320,7 +320,7 @@ } /** - * + * * @throws Exception Exception */ public void testSetFromWithEnconding() throws Exception @@ -333,7 +333,7 @@ InternetAddress inetExpected = new InternetAddress("[EMAIL PROTECTED]", "[EMAIL PROTECTED]"); - // set from + // set from this.email.setCharset(Email.ISO_8859_1); this.email.setFrom(testValidEmail); @@ -343,7 +343,7 @@ } /** - * + * * @throws Exception Exception */ public void testSetFrom2() throws Exception @@ -378,7 +378,7 @@ for (int i = 0; i < testEmails.length; i++) { - // set from + // set from this.email.setFrom(testEmails[i], testEmailNames[i]); // retrieve and verify @@ -443,7 +443,7 @@ { try { - // set from + // set from this.email.addTo(ARR_VALID_EMAILS[i]); } catch (EmailException e) @@ -489,7 +489,7 @@ { try { - // set from + // set from this.email.addTo(ARR_VALID_EMAILS[i]); } catch (EmailException e) @@ -536,7 +536,7 @@ { try { - // set from + // set from this.email.addTo(ARR_VALID_EMAILS[i], testEmailNames[i]); } catch (EmailException e) @@ -683,7 +683,7 @@ { try { - // set from + // set from this.email.addCc(ARR_VALID_EMAILS[i]); } catch (EmailException e) @@ -729,7 +729,7 @@ { try { - // set from + // set from this.email.addCc(ARR_VALID_EMAILS[i]); } catch (EmailException e) @@ -776,7 +776,7 @@ { try { - // set from + // set from this.email.addCc(ARR_VALID_EMAILS[i], testEmailNames[i]); } catch (EmailException e) @@ -905,7 +905,7 @@ { try { - // set from + // set from this.email.addBcc(ARR_VALID_EMAILS[i]); } catch (EmailException e) @@ -953,7 +953,7 @@ { try { - // set from + // set from this.email.addBcc(ARR_VALID_EMAILS[i]); } catch (EmailException e) @@ -1002,7 +1002,7 @@ { try { - // set from + // set from this.email.addBcc(ARR_VALID_EMAILS[i], testEmailNames[i]); } catch (EmailException e) @@ -1146,7 +1146,7 @@ { try { - // set from + // set from this.email.addReplyTo(ARR_VALID_EMAILS[i]); } catch (EmailException e) @@ -1194,7 +1194,7 @@ { try { - // set from + // set from this.email.addReplyTo(ARR_VALID_EMAILS[i]); } catch (EmailException e) @@ -1243,7 +1243,7 @@ { try { - // set from + // set from this.email.addReplyTo(ARR_VALID_EMAILS[i], testEmailNames[i]); } catch (EmailException e) Modified: jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/HtmlEmailTest.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/HtmlEmailTest.java?rev=240033&r1=240032&r2=240033&view=diff ============================================================================== --- jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/HtmlEmailTest.java (original) +++ jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/HtmlEmailTest.java Thu Aug 25 03:03:05 2005 @@ -178,7 +178,7 @@ } /** - * + * * @throws Exception Exception */ public void testEmbed() throws Exception @@ -350,7 +350,7 @@ } /** - * + * * @throws Exception Exception */ public void testSend2() throws Exception @@ -401,7 +401,7 @@ this.email.getCcList(), this.email.getBccList(), false); - + this.getMailServer(); this.email = new MockHtmlEmailConcrete(); @@ -445,7 +445,7 @@ this.email.getCcList(), this.email.getBccList(), false); - + } } Modified: jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/MultiPartEmailTest.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/MultiPartEmailTest.java?rev=240033&r1=240032&r2=240033&view=diff ============================================================================== --- jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/MultiPartEmailTest.java (original) +++ jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/MultiPartEmailTest.java Thu Aug 25 03:03:05 2005 @@ -206,7 +206,7 @@ e.printStackTrace(); fail("Unexpected exception thrown"); } - + // ==================================================================== // Test Exceptions // ==================================================================== @@ -434,7 +434,7 @@ } /** - * + * * @throws Exception Exception */ public void testAddPart() throws Exception @@ -460,11 +460,11 @@ .getBodyPart(0) .getDataHandler() .getContent()); - + } /** - * + * * @throws Exception Exception */ public void testAddPart2() throws Exception @@ -487,7 +487,7 @@ .getContentType() .indexOf(strSubtype) != -1); - + } /** @todo implement test for GetContainer */ Modified: jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockEmailConcrete.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockEmailConcrete.java?rev=240033&r1=240032&r2=240033&view=diff ============================================================================== --- jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockEmailConcrete.java (original) +++ jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockEmailConcrete.java Thu Aug 25 03:03:05 2005 @@ -28,7 +28,7 @@ import org.apache.commons.mail.EmailException; /** - * Concrete Implementation on the Abstract Email + * Concrete Implementation on the Abstract Email * Class (used to allow testing only). Supplies * getters for methods that normally only have setters. * @@ -46,7 +46,7 @@ */ public Email setMsg(String msg) { - // This abstract method should be tested in the concrete + // This abstract method should be tested in the concrete // implementation classes only. return null; } Modified: jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockHtmlEmailConcrete.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockHtmlEmailConcrete.java?rev=240033&r1=240032&r2=240033&view=diff ============================================================================== --- jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockHtmlEmailConcrete.java (original) +++ jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockHtmlEmailConcrete.java Thu Aug 25 03:03:05 2005 @@ -24,7 +24,7 @@ import org.apache.commons.mail.HtmlEmail; /** - * Extension of the HtmlEmail Class + * Extension of the HtmlEmail Class * (used to allow testing only) * * @since 1.0 Modified: jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockMultiPartEmailConcrete.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockMultiPartEmailConcrete.java?rev=240033&r1=240032&r2=240033&view=diff ============================================================================== --- jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockMultiPartEmailConcrete.java (original) +++ jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockMultiPartEmailConcrete.java Thu Aug 25 03:03:05 2005 @@ -24,7 +24,7 @@ import org.apache.commons.mail.MultiPartEmail; /** - * Extension of MultiPartEmail Class + * Extension of MultiPartEmail Class * (used to allow testing only) * * @since 1.0 Modified: jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockSimpleEmail.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockSimpleEmail.java?rev=240033&r1=240032&r2=240033&view=diff ============================================================================== --- jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockSimpleEmail.java (original) +++ jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/mocks/MockSimpleEmail.java Thu Aug 25 03:03:05 2005 @@ -22,7 +22,7 @@ import org.apache.commons.mail.SimpleEmail; /** - * Extension of SimpleEmail Class + * Extension of SimpleEmail Class * (used to allow testing only) * * @since 1.0 Modified: jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/settings/EmailConfiguration.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/settings/EmailConfiguration.java?rev=240033&r1=240032&r2=240033&view=diff ============================================================================== --- jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/settings/EmailConfiguration.java (original) +++ jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/settings/EmailConfiguration.java Thu Aug 25 03:03:05 2005 @@ -17,7 +17,7 @@ /** * @since 1.0 - * @author Eric Pugh + * @author Eric Pugh * @version $Revision$ $Date$ */ public final class EmailConfiguration Modified: jakarta/commons/proper/email/trunk/xdocs/changes.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/xdocs/changes.xml?rev=240033&r1=240032&r2=240033&view=diff ============================================================================== --- jakarta/commons/proper/email/trunk/xdocs/changes.xml (original) +++ jakarta/commons/proper/email/trunk/xdocs/changes.xml Thu Aug 25 03:03:05 2005 @@ -21,7 +21,7 @@ </properties> <body> - <release version="1.0-rc6-SNAPSHOT" date="IN Subversion"> + <release version="1.0-rc6-SNAPSHOT" date="IN Subversion"> <action dev="sgoeschl" type="update"> Refactoring the code to seperate creation of a MimeMessage and sending it. </action> @@ -32,48 +32,48 @@ </action> <action dev="epugh" type="add" due-to="Mark Lowe" issue="32094"> Email throws EmailException wrapping underlying JavaMail exception - </action> + </action> <action dev="epugh" type="add" due-to="Corey Scott" issue="32410"> Change port for dumbster from 25 to 2500 to use unreserved port. - </action> + </action> <action dev="epugh" type="add" due-to="Corey Scott" issue="32260"> Add back in ByteArrayDataSource. </action> <action dev="epugh" type="remove"> Removed deprecated MailMessage and ByteArrayDataSource. - </action> + </action> <action dev="epugh" type="add"> Output test emails to /target/test-emails as .txt files for manual review. - </action> + </action> <action dev="epugh" type="add" due-to="Mark Lowe" issue="31904"> Inline attatchment encoding was incorrect. - </action> + </action> <action dev="epugh" type="add"> Integrate our own checkstyle config instead of using Turbine style only. - </action> + </action> <action dev="epugh" type="add" due-to="Joe Germuska" issue="18968"> Clone the System.getProperties() call instead of putting random properties into it. - </action> + </action> <action dev="epugh" type="add" issue="16859"> Can't supply a javax.mail.Session to Commons Email component - </action> + </action> <action dev="epugh" type="add" issue="30973" due-to="Corey Scott"> HTML email with plain text alternative and attachments - </action> + </action> <action dev="epugh" type="add" issue="31762" due-to="Corey Scott"> Integrate use of Dumbster to supply a fake SMTP server. - </action> + </action> <action dev="epugh" type="add" due-to="Corey Scott"> Lots of new unit tests and cleanup of code. - </action> + </action> <action dev="epugh" type="update"> Update dependencies to latest available. </action> <action dev="germuska" type="add" issue="18968"> Support the delivery of bounced messages to an address other than "from". - </action> + </action> </release> </body> </document> Modified: jakarta/commons/proper/email/trunk/xdocs/examples.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/xdocs/examples.xml?rev=240033&r1=240032&r2=240033&view=diff ============================================================================== --- jakarta/commons/proper/email/trunk/xdocs/examples.xml (original) +++ jakarta/commons/proper/email/trunk/xdocs/examples.xml Thu Aug 25 03:03:05 2005 @@ -205,20 +205,20 @@ Technical notes: When SMTP servers cannot deliver mail, they do not pay any attention to the contents of the message to determine where the error notification should be sent. Rather, they refer to the SMTP "envelope sender" value. JavaMail sets this - value according to the value of the <code>mail.smtp.from</code> property on the - JavaMail <code>Session</code>. (Commons Email initializes the JavaMail + value according to the value of the <code>mail.smtp.from</code> property on the + JavaMail <code>Session</code>. (Commons Email initializes the JavaMail <code>Session</code> using <code>System.getProperties()</code>) If this property has not been set, then JavaMail uses the "from" address. If your email bean has the <code>bounceAddress</code> property set, then Commons Email uses it to set the value of <code>mail.smtp.from</code> - when the <code>Session</code> is initialized, overriding any other value + when the <code>Session</code> is initialized, overriding any other value which might have been set. </p> <p> - <em>Note: </em> This is the only way to control the handling of bounced email. + <em>Note: </em> This is the only way to control the handling of bounced email. Specifically, the "Errors-to:" SMTP header is deprecated and cannot be trusted - to control how a bounced message will be handled. Also note that it is considered bad - practice to send email with an untrusted "from" address unless you also set the + to control how a bounced message will be handled. Also note that it is considered bad + practice to send email with an untrusted "from" address unless you also set the bounce address. If your application allows users to enter an address which is used as the "from" address on an email, you should be sure to set the bounce address to a known good address. Modified: jakarta/commons/proper/email/trunk/xdocs/index.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/xdocs/index.xml?rev=240033&r1=240032&r2=240033&view=diff ============================================================================== --- jakarta/commons/proper/email/trunk/xdocs/index.xml (original) +++ jakarta/commons/proper/email/trunk/xdocs/index.xml Thu Aug 25 03:03:05 2005 @@ -74,7 +74,7 @@ cannot be recommended for production. </p> <p> -The sixth release candidate is now available for +The sixth release candidate is now available for <a href='http://people.apache.org/~epugh/commons-email/'>download</a> </p> </subsection> @@ -92,7 +92,7 @@ <section name="Development"> <p>Commons-Email may be used on any JRE from 1.3 onwards.</p> <p> - Please note that the tests may fail under JDK 1.3 due to the use of + Please note that the tests may fail under JDK 1.3 due to the use of <a href="http://sourceforge.net/projects/dumbster">Dumbster</a> which is compiled with JDK 1.4. </p> Modified: jakarta/commons/proper/email/trunk/xdocs/navigation.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/xdocs/navigation.xml?rev=240033&r1=240032&r2=240033&view=diff ============================================================================== --- jakarta/commons/proper/email/trunk/xdocs/navigation.xml (original) +++ jakarta/commons/proper/email/trunk/xdocs/navigation.xml Thu Aug 25 03:03:05 2005 @@ -20,9 +20,9 @@ <title>Commons Email</title> <body> <links> - <item name="Jakarta" + <item name="Jakarta" href="http://jakarta.apache.org"/> - <item name="Jakarta Commons" + <item name="Jakarta Commons" href="http://jakarta.apache.org/commons/"/> </links> <menu name="Commons Email"> --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]