Author: scolebourne
Date: Sat Aug 27 06:40:14 2005
New Revision: 240418
URL: http://svn.apache.org/viewcvs?rev=240418&view=rev
Log:
Fix IndexOutOfBoundsException on padding
bug 35756, from Reuben Sivan
Modified:
jakarta/commons/proper/lang/trunk/project.xml
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringUtilsTest.java
Modified: jakarta/commons/proper/lang/trunk/project.xml
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/lang/trunk/project.xml?rev=240418&r1=240417&r2=240418&view=diff
==============================================================================
--- jakarta/commons/proper/lang/trunk/project.xml (original)
+++ jakarta/commons/proper/lang/trunk/project.xml Sat Aug 27 06:40:14 2005
@@ -302,6 +302,9 @@
<name>Sean Schofield</name>
</contributor>
<contributor>
+ <name>Reuben Sivan</name>
+ </contributor>
+ <contributor>
<name>Ville Skytta</name>
</contributor>
<contributor>
Modified:
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java?rev=240418&r1=240417&r2=240418&view=diff
==============================================================================
---
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
Sat Aug 27 06:40:14 2005
@@ -110,6 +110,7 @@
* @author Phil Steitz
* @author Al Chou
* @author Michael Davey
+ * @author Reuben Sivan
* @since 1.0
* @version $Id$
*/
@@ -152,7 +153,7 @@
*
* <p>Used for efficient space padding. The length of each String expands
as needed.</p>
*/
- private static final String[] PADDING = new String[Character.MAX_VALUE];
+ private static final String[] PADDING = new String[Character.MAX_VALUE +
1];
static {
// space padding is most common, start with 64 chars
Modified:
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringUtilsTest.java
URL:
http://svn.apache.org/viewcvs/jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringUtilsTest.java?rev=240418&r1=240417&r2=240418&view=diff
==============================================================================
---
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringUtilsTest.java
(original)
+++
jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringUtilsTest.java
Sat Aug 27 06:40:14 2005
@@ -1126,6 +1126,7 @@
assertEquals(" ", StringUtils.leftPad("", 5, ' '));
assertEquals(" abc", StringUtils.leftPad("abc", 5, ' '));
assertEquals("xxabc", StringUtils.leftPad("abc", 5, 'x'));
+ assertEquals("\uffff\uffffabc", StringUtils.leftPad("abc", 5,
'\uffff'));
assertEquals("abc", StringUtils.leftPad("abc", 2, ' '));
String str = StringUtils.leftPad("aaa", 10000, 'a'); // bigger than
pad length
assertEquals(10000, str.length());
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
