-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi James,
James Carman wrote: > My comments are interleaved: > > [snip] > >>commons-proxy.imi, commons-proxy.ipr and lo4j.properties files need a >>license boilerplate. > > > I fixed log4j.properties, but every time I edit the Intellij IDEA files, > IDEA overwrites them. Am I not supposed to be including IDEA project/module > files? How about Eclipse .classpath and .project files? What's our policy > on this? I think you should never check in IDE config files! They will contain user specific preferences or favours. So this tends to become a commit war or at least causes trouble if someone commits a change and others update and get conflicts/merges. You could provide them as examples with different name/location in the svn, but you can generate the IDE settings for Eclipse and/or IntelliJ with maven so there is absolutely no need for having them in svn. Better add some lines about how to get startet and include the command to generate the IDE config with maven. Be aware, that if the POM (project.xml) changes (e.g. dependend jars change), the IDE config can be updated (regenerated) with maven. This is all about the idea of maven: single point of information. Avoid having redundancies as you have the dependencies in project.xml and the IntelliJ settings. > > [snip] Regards Jörg -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFDVzNlmPuec2Dcv/8RAu5zAJ49NFRhYiZP/AcfsadMk3PoFe3BKgCfXzUl gQq/NDm+TuHedvdFw65iqqQ= =sekE -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]