On 11/27/05, Niall Pemberton <[EMAIL PROTECTED]> wrote: > > Sorry Martin, I'm probably driving you mad. I just attached the 3rd patch > before I saw you'd accepted the second :-( > > I'll go away now.
;-) Actually, the second is more robust than the third in any case, since the default location for these files is the container's temp directory, which is very likely to be cleaned out on a server restart. And if the default isn't used, all bets are off anyway. I'm still apprehensive about the performance implications, if people don't think about what they're doing, but at least now DiskFileItem adheres to its contract. -- Martin Cooper Niall > > > ----- Original Message ----- > From: <[EMAIL PROTECTED]> > To: <commons-dev@jakarta.apache.org> > Sent: Monday, November 28, 2005 4:07 AM > Subject: DO NOT REPLY [Bug 32785] - [fileupload] FileItem implements > Serializable incorrectly > > > > DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· > > RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT > > <http://issues.apache.org/bugzilla/show_bug.cgi?id=32785>. > > ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· > > INSERTED IN THE BUG DATABASE. > > > > http://issues.apache.org/bugzilla/show_bug.cgi?id=32785 > > > > > > [EMAIL PROTECTED] changed: > > > > What |Removed |Added > > > -------------------------------------------------------------------------- > -- > > Attachment #17059|0 |1 > > is obsolete| | > > > > > > > > > > ------- Additional Comments From [EMAIL PROTECTED] 2005-11-28 > 05:07 ------- > > Created an attachment (id=17060) > > --> > (http://issues.apache.org/bugzilla/attachment.cgi?id=17060&action=view) > > 3rd Patch for DiskFileItem > > > > I guess the 2nd patch isn't a great idea either since its not > v.efficient > > copying a ton of data. > > > > Attaching a 3rd patch - if its not "in memory" this one caches the File > that > > DeferredFileOutputStream has written to when serializing. Everywhere > that > > referenced the DeferredFileOutputStream now checks to see if that File > is > there > > first. If it is "in memory" it re-creates the DeferredFileOutputStream. > > > > -- > > Configure bugmail: > http://issues.apache.org/bugzilla/userprefs.cgi?tab=email > > ------- You are receiving this mail because: ------- > > You are the assignee for the bug, or are watching the assignee. > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
