DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=35828>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=35828 ------- Additional Comments From [EMAIL PROTECTED] 2005-12-30 19:00 ------- Hey, great stuff. Thanks very much, Jorge! Everything looks good to me except for two minor points in AbstractConfiguration: - You have simply renamed the setDelimiter() method to setDefaultListDelimiter(). Because of binary backwards compatibility we cannot remove methods from this class, so get/setDelimiter() need to remain there. They should be marked as deprecated and delegate to get/setDefaultListDelimiter(). - The field that stores the default list delimiter is named in upper case. This will cause a checkstyle warning because it is not a constant. So the name should be defaultListDelimiter (I see this was already wrong in the initial comment of this ticket). Thanks again for your work! -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
