DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=38174>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38174 Summary: [logging][PATCH] Improvements to wrapper classes Product: Commons Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P2 Component: Logging AssignedTo: commons-dev@jakarta.apache.org ReportedBy: [EMAIL PROTECTED] There are several issues with the wrapper classes. 1) Logging null objects or not If the message object is null, the logger logs the String "NULL" to the underlying log system. Currently some wrappers just return and some log the String "NULL". -> The patch unifies that. All wrappers will log the String "NULL". 2) Exception safe toString Currently all wrappers would fail if an toString method throws a RuntimeException. See http://marc.theaimsgroup.com/?l=jakarta-commons-dev&m=113664590418487&w=2 for details. -> The patch logs an error message instead and an additional log record with the exception in a central, private doLog method. 3) isLoggable check Currently some wrappers check the log level in each log method and some wrappers check the level in one central method, which applies the log message and throwable to the underlying log system. -> The patch unifies that. All wrappers will use a doLog method and check the level there. One exception: AvalonLogger which has no Level/Priority object. 3) JavaDoc Every wrapper has its own javadoc for the log methods, sometime with reference to the Log interface, sometimes with the underlying log level, ... -> The patch unifies that. All wrapper log methods are commented in the same way. 4) Additional class There is one additional class for the error message, to have a single point of change. Please check the patch for correct format. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
