On 2/12/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: <snip/>
Peter- I am moving this to the dev list since your comment involves much more than issue 38459 [1], and its probably useful to do a quick review of the status of [scxml] here, rather than in Bugzilla. > > ------- Additional Comments From [EMAIL PROTECTED] 2006-02-12 20:04 ------- > Rahul, > > What else needs to be tested, or what is the priority of testing you would > like > done on this? <snap/> Thanks to the numerous test you've written over the last couple of weeks, I think we are in fair shape as indicated by cobertura, most of the classes which are doing poorly in terms of test coverage are in the environment and test packages, which (one or more may apply): 1) Are harder to test as they possibly need a suite of environment-specific mock objects 2) Have been tested indirectly via the usecases 3) Are simple environment specific wrappers or adapters that can scale to visual inspection 4) Are command-line testing classes where it makes little sense to write JUnit tests For now, I was planning on focusing a bit more on tests that exercise executions of state machines, for example: a) Enhancing the couple of SCXMLExecutor tests for the microwave samples -- see methods checkMicrowave{01,02}Sample() [2] -- to do much more (add "time", "door_open", "door_close", "turn_on", "turn_off" events and expected outcomes in various permutations) b) Adding a few "stress tests" for the SCXMLExecutor class (along the lines of comment #8 [3] for bug 38459). c) Adding more "sample" SCXML documents, think of any state machine -- here is one suggestion we should author anyway [4] -- and write up a test case that executes the document (ofcourse, with multiple differing sequences of events and outcomes). > I was going to continue testing SCXMLSerializer, but if I > remember correctly, you said that was going away or was being replaced by > Digester. <snip/> By betwixt, possibly. But you're right, I wouldn't recommend spending your cycles there for now. > Aside from testing, what are other features you would like people to > work on? > <snap/> Not meaning to sound clichéd, but for any Apache project, the short answer always is - whatever takes your fancy. With that disclaimer, the two "features" that are high priority are: i) Tim O'Brien's suggestion of using betwixt [5] for SCXML IO. We don't have to use betwixt, as long as we can explain why we aren't using it ;-) And towards that end, this exploration needs to be done. ii) Documentation. For example, issues 38274 [4], 38275 [6] and 38276 [7] need to be resolved and this wiki FAQ page [8] needs to be populated. And then some more, if we get to that point ;-) I'll take care of the questions on the wiki shortly, which might even give us what we need for the web pages mentioned in issues 382{75,76}. A big help would be to just proof-read (grammar, spelling) and do a technical review of the Javadocs for the component [9]. Javadocs need to be: * correct * concise * understandable and meaningful (to a benchmark Java developer that uses Commons libraries) * adequately cross-referenced (for example, using @see tags) Javadocs patches are therefore, welcome. Patches to the xdocs [10] are also good help. IMO, addressing these makes us ready to attempt sandbox graduation again (the first vote, about a month ago, was unsuccessful). Anything else beyond the two points above is a freebie at this point since sandbox graduation is now overdue, in my strictly personal opinion. Thanks for your interest, and for asking. Please feel free to add any things that you'd like to see done. -Rahul [1] http://issues.apache.org/bugzilla/show_bug.cgi?id=38459 [2] http://svn.apache.org/viewcvs.cgi/jakarta/commons/sandbox/scxml/trunk/src/test/java/org/apache/commons/scxml/SCXMLExecutorTest.java?view=markup [3] http://issues.apache.org/bugzilla/show_bug.cgi?id=38459#c8 [4] http://issues.apache.org/bugzilla/show_bug.cgi?id=38274 [5] http://jakarta.apache.org/commons/betwixt/ [6] http://issues.apache.org/bugzilla/show_bug.cgi?id=38275 [7] http://issues.apache.org/bugzilla/show_bug.cgi?id=38276 [8] http://wiki.apache.org/jakarta-commons/SCXML/SCXMLFaq [9] http://jakarta.apache.org/commons/sandbox/scxml/apidocs/index.html [10] http://svn.apache.org/viewcvs.cgi/jakarta/commons/sandbox/scxml/trunk/xdocs/ > Peter > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]