Modified: jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestStackKeyedObjectPool.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestStackKeyedObjectPool.java?rev=386186&r1=386185&r2=386186&view=diff ============================================================================== --- jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestStackKeyedObjectPool.java (original) +++ jakarta/commons/proper/pool/trunk/src/test/org/apache/commons/pool/impl/TestStackKeyedObjectPool.java Wed Mar 15 14:28:20 2006 @@ -44,7 +44,11 @@ StackKeyedObjectPool pool = new StackKeyedObjectPool(new SimpleFactory(),mincapacity); return pool; } - + + protected KeyedObjectPool makeEmptyPool(KeyedPoolableObjectFactory factory) { + return new StackKeyedObjectPool(factory); + } + protected Object getNthObject(Object key, int n) { return String.valueOf(key) + String.valueOf(n); } @@ -228,8 +232,7 @@ } public void testBorrowReturnWithSometimesInvalidObjects() throws Exception { - KeyedObjectPool pool = new StackKeyedObjectPool(); - pool.setFactory( + KeyedObjectPool pool = new StackKeyedObjectPool( new KeyedPoolableObjectFactory() { int counter = 0; public Object makeObject(Object key) { return new Integer(counter++); } @@ -261,7 +264,7 @@ for(int i=0;i<10;i++) { pool.returnObject("key",obj[i]); } - assertEquals(3,pool.getNumIdle("key")); + assertEquals(6,pool.getNumIdle("key")); } class SimpleFactory implements KeyedPoolableObjectFactory {
Modified: jakarta/commons/proper/pool/trunk/xdocs/changes.xml URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/pool/trunk/xdocs/changes.xml?rev=386186&r1=386185&r2=386186&view=diff ============================================================================== --- jakarta/commons/proper/pool/trunk/xdocs/changes.xml (original) +++ jakarta/commons/proper/pool/trunk/xdocs/changes.xml Wed Mar 15 14:28:20 2006 @@ -23,6 +23,26 @@ <release version="2.0" date="pending" description="Significant clean ups"> <action dev="sandymac" type="fix"> + Edited all KeyedObjectPool related JavaDocs to have meaningful and correct content. + </action> + <action dev="sandymac" type="fix"> + Implemented until tests to verify KeyedObjectPool implementations conformed to Pool 2 contracts. + Updated GenericKeyedObjectPool and StackKeyedObjectPool to conformant behavior. + </action> + <action dev="sandymac" type="fix"> + Don't ignore maxTotal parameter in + <code>GenericKeyedObjectPool(KeyedPoolableObjectFactory factory, int maxActive, byte whenExhaustedAction, + long maxWait, int maxIdle, int maxTotal, boolean testOnBorrow, boolean testOnReturn, + long timeBetweenEvictionRunsMillis, int numTestsPerEvictionRun, long minEvictableIdleTimeMillis, + boolean testWhileIdle)</code> + </action> + <action dev="sandymac" type="fix"> + Change StackKeyedObjectPool to discard stalest, not freshest, idle object when maxSleeping is reached. + </action> + <action dev="sandymac" type="fix"> + Edited all ObjectPool related JavaDocs to have meaningful and correct content. + </action> + <action dev="sandymac" type="fix"> Implemented until tests to verify ObjectPool implementations conformed to Pool 2 contracts. Updated GenericObjectPool, StackObjectPool, and SoftReferenceObjectPool to conformant behavior. </action> --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
