On Thu, 2006-05-11 at 20:55 +0100, Stephen Colebourne wrote: > Thanks for the feedback, I'll fix the stuff mentioned before release. > > The clirr report is available from an 'ant clirr'. It shows no issues:
> > INFO: 7011: org.apache.commons.collections.BufferUtils: Method 'public > org.apache.commons.collections.Buffer > blockingBuffer(org.apache.commons.collections.Buffer, long)' has been added > INFO: 7011: org.apache.commons.collections.BufferUtils: Method 'public > org.apache.commons.collections.Buffer > boundedBuffer(org.apache.commons.collections.Buffer, int)' has been added > INFO: 7011: org.apache.commons.collections.BufferUtils: Method 'public > org.apache.commons.collections.Buffer > boundedBuffer(org.apache.commons.collections.Buffer, int, long)' has > been added None of these changes are in the release notes (though all are correctly documented with @since 1.2). Admittedly, they are implied by the addition of the new constructors on BlockingBuffer and BoundedBuffer which are documented. Still, I think a one-line entry in the release notes saying that the BufferUtils class has been extended to match the new constructors would be nice. > INFO: 7011: org.apache.commons.collections.ClosureUtils: Method 'public > org.apache.commons.collections.Closure > ifClosure(org.apache.commons.collections.Predicate, > org.apache.commons.collections.Closure)' has been added As for BufferUtils above. > INFO: 7011: org.apache.commons.collections.IteratorUtils: Method 'public > org.apache.commons.collections.ResettableIterator > loopingListIterator(java.util.List)' has been added As for BufferUtils > INFO: 7011: org.apache.commons.collections.MapUtils: Method 'public > java.util.Map multiValueMap(java.util.Map)' has been added > INFO: 7011: org.apache.commons.collections.MapUtils: Method 'public > java.util.Map multiValueMap(java.util.Map, java.lang.Class)' has been added > INFO: 7011: org.apache.commons.collections.MapUtils: Method 'public > java.util.Map multiValueMap(java.util.Map, > org.apache.commons.collections.Factory)' has been added As for BufferUtils > INFO: 7011: org.apache.commons.collections.buffer.BlockingBuffer: Method > 'public org.apache.commons.collections.Buffer > decorate(org.apache.commons.collections.Buffer, long)' has been added Not mentioned in release notes. These are pretty trivial points. All the methods above *do* have the correct @since info. More importantly, there seem to be no backwards compatibility issues. So as long as the Manifest issue raised by Robert is dealt with, I'm +1 on this release. Congrats to all the contributors to the 3.2 fixes and features; this all looks like good stuff. Regards, Simon --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
