[ 
http://issues.apache.org/jira/browse/JELLY-230?page=comments#action_12402354 ] 

Lukas Theussl commented on JELLY-230:
-------------------------------------

The replaceNamespace thingy doesn't work for me. I may be doing something wrong 
or be missing something, but here is the beginning of the generated build.xml:

<x:replaceNamespace xmlns:x="jelly:xml" toURI="" fromURI="dummy">
  <project xmlns="dummy" default="jar" basedir="." name="test-maven-ant-plugin">

ie the <x:replaceNamespace> gets translated verbatim, even though I have a 
<x:comment> just before that which gets correctly translated into a comment. I 
tried with jelly-tags-xml-1.1 and 1.2-SNAPSHOT from svn.

Anyway, Paul is right that my main concern is backwards compatibility: we would 
have to adjust a number of plugins and they would all be incompatible with 
older maven releases (the latest stable maven 1.0.2 in particular). Also I 
don't think that this is specific to Maven (at least I am not aware of "dummy" 
having any special treatment in maven). The problem is: how to generate a file 
without namespace declaration from a template where I need to declare a default 
namespace in order to distinguish it from the default namespace of the 
application that parses the template?

> Problem with default namespace in imported scripts
> --------------------------------------------------
>
>          Key: JELLY-230
>          URL: http://issues.apache.org/jira/browse/JELLY-230
>      Project: Jelly
>         Type: Bug

>   Components: core / taglib.core
>     Versions: 1.1
>  Environment: jelly-1.1-SNAPSHOT
>     Reporter: Lukas Theussl
>     Assignee: james strachan
>     Priority: Critical

>
> I am trying to build Maven with jelly-1.1-SNAPSHOT from svn trunk because it 
> contains a fix for a regression that has blocked us for a long time, see
> http://jira.codehaus.org/browse/MAVEN-1691 (gee, I wish I'd checked the svn 
> archives earlier!).
> However, even though jelly-1.1-SNAPSHOT solves the above issue, it also leads 
> to a whole bunch of test failures in several of our plugins.
> After some investigation I found that they all turn out to be due to the same 
> cause, an apparent backwards incompatibility introduced in the fix for 
> JELLY-213.
> I am not sure actually if this is a bug or the intended behavior, but it 
> certainly breaks backwards compatibility.
> To illustrate the problem: in the ant plugin we use the following snippet to 
> generate an ant build.xml file from a template:
> <j:file name="build.xml" prettyPrint="true">
>   <j:import file="templates/build.jelly" inherit="true"/>
> </j:file>
> where the template file build.jelly looks like this (simplified):
> <j:jelly
>   xmlns:ant="jelly:ant"
>   xmlns:j="jelly:core" 
>   xmlns="dummy">
>   <project name="${pom.artifactId}" default="jar" basedir=".">
>       <target name="clean" description="Clean up">
>         <delete dir="$${defaulttargetdir}"/>
>         <delete dir="$${distdir}"/>
>       </target>
>   </project>
> </j:jelly>
> Note the xmlns="dummy" namespace declaration which is necessary to 
> distinguish the default namespace of the template script from Maven's default 
> namespace. Now with jelly-1.0, this works as expected, but with the current 
> jelly-1.1-SNAPSHOT, I get:
> <project xmlns="dummy" name="test-maven-ant-plugin" default="jar" basedir=".">
>   <target description="Clean up" name="clean">
>     <delete dir="${defaulttargetdir}">
>     </delete>
>     <delete dir="${distdir}">
>     </delete>
>   </target>
> <project>
> ie the dummy namespace declaration makes it into the top-level element of the 
> generated file. This makes ant very unhappy when invoked on this build file...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to