[ http://issues.apache.org/jira/browse/SCXML-28?page=comments#action_12439578 ] Rahul Akolkar commented on SCXML-28: ------------------------------------
Thanks for your time and the changes. Few comments: 1) The addition of Javadocs has introduced @author tags. Commons SCXML code does not contain those tags, the only attribution is the list on the team page on the website. The tags will need to be removed before this gets into the codebase, if it is accepted. 2) There are no test cases. Please look at the test suite and provide some test SCXML documents using pnuts along with the JUnit test cases. 3) We will also need to update the site documentation (such as the section on contexts and evaluators in the user guide) at the same time. 4) Is pnuts in a Maven 1 repository somewhere? If not, we will need that to happen first (might involve pinging the pnuts lists, are you subscribed there?). Finally, please let us know when your ICLA is sent and we can come back to this ticket then. > Support for the pnuts scripting language > ---------------------------------------- > > Key: SCXML-28 > URL: http://issues.apache.org/jira/browse/SCXML-28 > Project: Commons SCXML > Issue Type: New Feature > Affects Versions: 0.5 > Reporter: Hallvard Trætteberg > Priority: Minor > Fix For: 1.0 > > Attachments: PnutsContext.java, PnutsEvaluator.java, > PnutsEvaluator.java, PnutsEvaluator.java > > > Add support for the pnuts scripting language. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
