[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12441483 ] Stephen Colebourne commented on IO-86: --------------------------------------
Why a boolean? Firstly, because it reduces the jar file size slightly (each class is an overhead), but secondly because I wanted the handlers to be able to ignore the cancellation request (which they can't do with an exception because its too late by that point). What you're suggesting now could almost argue for no cancellation behaviour at all - what does CancelledOperation(Exception) give over throwing an IOException directly? I do agree that the code I checked in doesn't support the internal model of cancellation. This could be fixed by adding a setCancelled() method and a boolean flag. Maybe we are worrying too much about the sync cost of volatile? > Add DirectoryWalker based on FileFinder > --------------------------------------- > > Key: IO-86 > URL: http://issues.apache.org/jira/browse/IO-86 > Project: Commons IO > Issue Type: New Feature > Components: Utilities > Affects Versions: 1.2 > Reporter: Niall Pemberton > Fix For: 1.3 > > Attachments: FileFinder.java, FileFinderTestCase.java, > io-DirectoryWalker-cancellation-2.patch, io-filefinder-start-end.patch > > > I'd like to propose adding a "FileFinder" back into Commons IO. This is a > simplified version of what was recently moved out of Commons IO into the > "finder" component currently in the sandbox. > I believe this is a simpler, more generic implementation than the finder > component and therefore would be considered suitable for inclusion in Commons > IO. Although simpler it could be used as the basis for achieving the finder > component's aims - namely to emulate the unix find command. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
