Author: bayard
Date: Tue Oct 31 17:15:35 2006
New Revision: 469736
URL: http://svn.apache.org/viewvc?view=rev&rev=469736
Log:
Applied the unnecessary-semicolon-fix-java.patch from #BEANUTILS-121
Modified:
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/BeanUtilsBean.java
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/MappedPropertyDescriptor.java
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/MethodUtils.java
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/locale/LocaleBeanUtils.java
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/locale/LocaleBeanUtilsBean.java
Modified:
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/BeanUtilsBean.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/BeanUtilsBean.java?view=diff&rev=469736&r1=469735&r2=469736
==============================================================================
---
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/BeanUtilsBean.java
(original)
+++
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/BeanUtilsBean.java
Tue Oct 31 17:15:35 2006
@@ -262,7 +262,7 @@
getPropertyUtils().getSimpleProperty(orig, name);
copyProperty(dest, name, value);
} catch (NoSuchMethodException e) {
- ; // Should not happen
+ // Should not happen
}
}
}
@@ -365,7 +365,8 @@
index =
Integer.parseInt(propName.substring(i + 1, k));
} catch (NumberFormatException e) {
- ;
+ // Swallow NumberFormatException
+ // TODO: Why?
}
propName = propName.substring(0, i);
}
@@ -375,7 +376,8 @@
try {
key = propName.substring(j + 1, k);
} catch (IndexOutOfBoundsException e) {
- ;
+ // Swallow IndexOutOfBoundsException
+ // TODO: Why?
}
propName = propName.substring(0, j);
}
@@ -932,7 +934,8 @@
index =
Integer.parseInt(propName.substring(i + 1, k));
} catch (NumberFormatException e) {
- ;
+ // Swallow NumberFormatException
+ // TODO: Why?
}
propName = propName.substring(0, i);
}
@@ -942,7 +945,8 @@
try {
key = propName.substring(j + 1, k);
} catch (IndexOutOfBoundsException e) {
- ;
+ // Swallow IndexOutOfBoundsException
+ // TODO: Why?
}
propName = propName.substring(0, j);
}
Modified:
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/MappedPropertyDescriptor.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/MappedPropertyDescriptor.java?view=diff&rev=469736&r1=469735&r2=469736
==============================================================================
---
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/MappedPropertyDescriptor.java
(original)
+++
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/MappedPropertyDescriptor.java
Tue Oct 31 17:15:35 2006
@@ -111,7 +111,9 @@
Class params[] = { String.class, mappedReadMethod.getReturnType()
};
mappedWriteMethod = getMethod(beanClass, "set" + base, params);
} catch (IntrospectionException e) {
- ;
+ /* Swallow IntrospectionException
+ * TODO: Why?
+ */
}
// If there's no read method, then look for just a write method
Modified:
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/MethodUtils.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/MethodUtils.java?view=diff&rev=469736&r1=469735&r2=469736
==============================================================================
---
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/MethodUtils.java
(original)
+++
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/MethodUtils.java
Tue Oct 31 17:15:35 2006
@@ -488,7 +488,9 @@
method = interfaces[i].getDeclaredMethod(methodName,
parameterTypes);
} catch (NoSuchMethodException e) {
- ;
+ /* Swallow, if no method is found after the loop then this
+ * method returns null.
+ */
}
if (method != null)
break;
Modified:
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/locale/LocaleBeanUtils.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/locale/LocaleBeanUtils.java?view=diff&rev=469736&r1=469735&r2=469736
==============================================================================
---
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/locale/LocaleBeanUtils.java
(original)
+++
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/locale/LocaleBeanUtils.java
Tue Oct 31 17:15:35 2006
@@ -452,7 +452,7 @@
Integer.parseInt(propName.substring(i + 1, k));
}
catch (NumberFormatException e) {
- ;
+ /* Swallow NumberFormatException */
}
propName = propName.substring(0, i);
}
@@ -463,7 +463,7 @@
key = propName.substring(j + 1, k);
}
catch (IndexOutOfBoundsException e) {
- ;
+ /* Swallow IndexOutOfBoundsException */
}
propName = propName.substring(0, j);
}
Modified:
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/locale/LocaleBeanUtilsBean.java
URL:
http://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/locale/LocaleBeanUtilsBean.java?view=diff&rev=469736&r1=469735&r2=469736
==============================================================================
---
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/locale/LocaleBeanUtilsBean.java
(original)
+++
jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/locale/LocaleBeanUtilsBean.java
Tue Oct 31 17:15:35 2006
@@ -878,7 +878,9 @@
Integer.parseInt(propName.substring(i + 1, k));
}
catch (NumberFormatException e) {
- ;
+ /* Swallow NumberFormatException
+ * TODO: Why?
+ */
}
propName = propName.substring(0, i);
}
@@ -889,7 +891,9 @@
key = propName.substring(j + 1, k);
}
catch (IndexOutOfBoundsException e) {
- ;
+ /* Swallow NumberFormatException
+ * TODO: Why?
+ */
}
propName = propName.substring(0, j);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
