[ http://issues.apache.org/jira/browse/BEANUTILS-121?page=all ]

Henri Yandell resolved BEANUTILS-121.
-------------------------------------

    Resolution: Fixed

Applied:

r469737 - remove-unused-code.patch 
r469728 - remove-unused-imports-test.patch 
r469729 - local-variable-not-read-warning-fix.patch 
r469730 - field-hiding-another-field-warning-fix.patch
r469731 - empty-block-should-be-documented-warning-fix-java.patch
r469732 - static-used-improperly-warning-fix.patch 
r469736 - unnecessary-semicolon-fix-java.patch
r469740 - remove-unused-imports-java.patch 

private-never-read-warning-fix.patch was already fixed.

I'm punting the unnecessary-else fix. I'm not a huge fan of the style of ending 
with an if/else, but I do think it's a style thing rather than something that 
can be considered wrong.

> [beanutils][PATCH] Easy warning fixes.
> --------------------------------------
>
>                 Key: BEANUTILS-121
>                 URL: http://issues.apache.org/jira/browse/BEANUTILS-121
>             Project: Commons BeanUtils
>          Issue Type: Bug
>         Environment: Operating System: Linux
> Platform: Other
>            Reporter: Chris Tilden
>            Priority: Minor
>             Fix For: 1.8.0
>
>         Attachments: empty-block-should-be-documented-warning-fix-java.patch, 
> field-hiding-another-field-warning-fix.patch, 
> local-variable-not-read-warning-fix.patch, 
> private-never-read-warning-fix.patch, remove-unused-code.patch, 
> remove-unused-imports-java.patch, remove-unused-imports-test.patch, 
> static-used-improperly-warning-fix.patch, unnecessary-else-fix-test.patch, 
> unnecessary-semicolon-fix-java.patch
>
>
> Hi,
> I was examining the source for beanutils using Eclipse. There were several
> warnings given, which I have fixed with the attached patches.
> These patches are pretty straightforeward, I think. :-)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to