svn commit: r472836 - /jakarta/commons/proper/digester/trunk/src/java/org/apache/commons/digester/SetNestedPropertiesRule.java

[skitching]

Author: skitching
Date: Thu Nov  9 02:06:56 2006
New Revision: 472836

URL: http://svn.apache.org/viewvc?view=rev&rev=472836
Log:
Minor code cleanup: 
* "log" is digester.log, so use shorter path.
* cache isDebugEnabled state in local variable

Modified:
    
jakarta/commons/proper/digester/trunk/src/java/org/apache/commons/digester/SetNestedPropertiesRule.java

Modified: 
jakarta/commons/proper/digester/trunk/src/java/org/apache/commons/digester/SetNestedPropertiesRule.java
URL: 
http://svn.apache.org/viewvc/jakarta/commons/proper/digester/trunk/src/java/org/apache/commons/digester/SetNestedPropertiesRule.java?view=diff&rev=472836&r1=472835&r2=472836
==============================================================================
--- 
jakarta/commons/proper/digester/trunk/src/java/org/apache/commons/digester/SetNestedPropertiesRule.java
 (original)
+++ 
jakarta/commons/proper/digester/trunk/src/java/org/apache/commons/digester/SetNestedPropertiesRule.java
 Thu Nov  9 02:06:56 2006
@@ -392,8 +392,6 @@
         }
         
         public void body(String value) throws Exception {
-            boolean debug = log.isDebugEnabled();
-
             String propName = currChildElementName;
             if (elementNames.containsKey(currChildElementName)) {
                 // overide propName
@@ -404,21 +402,23 @@
                 }
             }
     
-            if (digester.log.isDebugEnabled()) {
-                digester.log.debug("[SetNestedPropertiesRule]{" + 
digester.match +
+            boolean debug = log.isDebugEnabled();
+
+            if (debug) {
+                log.debug("[SetNestedPropertiesRule]{" + digester.match +
                         "} Setting property '" + propName + "' to '" +
                         value + "'");
             }
     
             // Populate the corresponding properties of the top object
             Object top = digester.peek();
-            if (digester.log.isDebugEnabled()) {
+            if (debug) {
                 if (top != null) {
-                    digester.log.debug("[SetNestedPropertiesRule]{" + 
digester.match +
+                    log.debug("[SetNestedPropertiesRule]{" + digester.match +
                                        "} Set " + top.getClass().getName() +
                                        " properties");
                 } else {
-                    digester.log.debug("[SetPropertiesRule]{" + digester.match 
+
+                    log.debug("[SetPropertiesRule]{" + digester.match +
                                        "} Set NULL properties");
                 }
             }
@@ -452,7 +452,7 @@
             BeanUtils.setProperty(top, propName, value);
             }
             catch(NullPointerException e) {
-                digester.log.error("NullPointerException: "
+                log.error("NullPointerException: "
                  + "top=" + top + ",propName=" + propName + ",value=" + value 
+ "!");
                  throw e;
             }



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]